Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 357783003: Remove some unnecessary ifs. (Closed)

Created:
6 years, 6 months ago by eroman
Modified:
6 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Remove some unnecessary ifs. scoped_ptr<> only calls the deleter when the data is non-null Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M crypto/scoped_nss_types.h View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
eroman
6 years, 6 months ago (2014-06-25 21:40:18 UTC) #1
Ryan Sleevi
lgtm
6 years, 6 months ago (2014-06-25 23:06:57 UTC) #2
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 6 months ago (2014-06-25 23:18:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/357783003/1
6 years, 6 months ago (2014-06-25 23:20:38 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-26 00:56:49 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-26 01:13:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/25702)
6 years, 6 months ago (2014-06-26 01:13:57 UTC) #7
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 6 months ago (2014-06-26 01:42:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/357783003/1
6 years, 6 months ago (2014-06-26 01:44:15 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-26 01:56:45 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-26 02:10:22 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/25702)
6 years, 6 months ago (2014-06-26 02:10:23 UTC) #12
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 5 months ago (2014-07-18 02:00:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/357783003/1
6 years, 5 months ago (2014-07-18 02:02:12 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 02:59:42 UTC) #15
Message was sent while issue was closed. 
Change committed as 283980

Powered by Google App Engine
This is Rietveld 408576698