Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 357773002: Pepper: Refactor OpenManifestEntry. (Closed)

Created:
6 years, 6 months ago by teravest
Modified:
6 years, 6 months ago
Reviewers:
bbudge
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Pepper: Refactor OpenManifestEntry. This change pulls out more OpenManifestEntry code from service_runtime, making PPB_NaCl_Private a smallter interface, and preparing for pulling all of that logic out of the trusted plugin. An earlier version of this change was reverted after breaking Non-SFI mode, but the Non-SFI case no longer uses this codepath. CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32 BUG=239656 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279832

Patch Set 1 #

Patch Set 2 : PP_Bool fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -132 lines) Patch
M components/nacl/renderer/ppb_nacl_private_impl.cc View 1 9 chunks +41 lines, -49 lines 0 comments Download
M ppapi/api/private/ppb_nacl_private.idl View 3 chunks +11 lines, -13 lines 0 comments Download
M ppapi/c/private/ppb_nacl_private.h View 4 chunks +11 lines, -12 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/service_runtime.cc View 1 chunk +6 lines, -45 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 4 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
teravest
6 years, 6 months ago (2014-06-25 19:02:29 UTC) #1
bbudge
lgtm
6 years, 6 months ago (2014-06-25 19:54:32 UTC) #2
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 6 months ago (2014-06-25 20:10:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/357773002/20001
6 years, 6 months ago (2014-06-25 20:10:54 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 22:01:24 UTC) #5
Message was sent while issue was closed.
Change committed as 279832

Powered by Google App Engine
This is Rietveld 408576698