Implement prediction_options.

chrome/browser/profiles/profile_io_data.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_
 
+#include <map>
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/callback_forward.h"
 #include "base/files/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/prefs/pref_member.h"
 #include "base/synchronization/lock.h"
@@ skipping 160 matching lines @@
   }
 
   BooleanPrefMember* sync_disabled() const {
     return &sync_disabled_;
   }
 
   BooleanPrefMember* signin_allowed() const {
     return &signin_allowed_;
   }
 
+  // TODO(bnc): remove per https://crbug.com/334602.
   BooleanPrefMember* network_prediction_enabled() const {
     return &network_prediction_enabled_;
   }
 
+  IntegerPrefMember* allow_network_prediction() const {

[mmenke, 2014/06/26 20:41:02]

Using an integer for something named "allow_network_prediction", which sounds
like a bool, seems wrong to me.  You called the enum "NetworkPredictionOptions"
in the other CL, which is better.  Not perfect, but I have no better ideas.

[Bence, 2014/06/27 15:11:51]

Great catch.  Let's do some brainstorming before we rename this preference, it
would already have to be changed at a lot of places, including
https://codereview.chromium.org/336543003.

[Bence, 2014/06/27 18:26:45]

Done.

+    return &allow_network_prediction_;
+  }
+
   content::ResourceContext::SaltCallback GetMediaDeviceIDSalt() const;
 
   DevToolsNetworkController* network_controller() const {
     return network_controller_.get();
   }
 
   net::TransportSecurityState* transport_security_state() const {
     return transport_security_state_.get();
   }
 
@@ skipping 324 matching lines @@
   // Member variables which are pointed to by the various context objects.
   mutable BooleanPrefMember enable_referrers_;
   mutable BooleanPrefMember enable_do_not_track_;
   mutable BooleanPrefMember force_safesearch_;
   mutable BooleanPrefMember safe_browsing_enabled_;
   mutable BooleanPrefMember data_reduction_proxy_enabled_;
   mutable BooleanPrefMember printing_enabled_;
   mutable BooleanPrefMember sync_disabled_;
   mutable BooleanPrefMember signin_allowed_;
   mutable BooleanPrefMember network_prediction_enabled_;
+  mutable IntegerPrefMember allow_network_prediction_;
   // TODO(marja): Remove session_startup_pref_ if no longer needed.
   mutable IntegerPrefMember session_startup_pref_;
   mutable BooleanPrefMember quick_check_enabled_;
   mutable IntegerPrefMember incognito_availibility_pref_;
 
   // The state of metrics reporting in the browser that this profile runs on.
   // Unfortunately, since ChromeOS has a separate representation of this state,
   // we need to make one available based on the platform.
 #if defined(OS_CHROMEOS)
   bool enable_metrics_;
@@ skipping 51 matching lines @@
 
   // TODO(jhawkins): Remove once crbug.com/102004 is fixed.
   bool initialized_on_UI_thread_;
 
   const Profile::ProfileType profile_type_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileIOData);
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_