Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 357693004: Revert of Add PRESUBMIT.py warning for contradictory NOTREACHED() use. (Closed)

Created:
6 years, 6 months ago by Miguel Garcia
Modified:
6 years, 6 months ago
Reviewers:
Thiemo Nagel, M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Add PRESUBMIT.py warning for contradictory NOTREACHED() use. (https://codereview.chromium.org/344563003/) Reason for revert: It seems to be checking code that is not part of the diff. I also think there are some legitimate cases for not reached in the middle of a block but that is something that can be discussed on the bug. Filed https://code.google.com/p/chromium/issues/detail?id=388731 to track. Original issue's description: > Add PRESUBMIT.py warning for contradictory NOTREACHED() use. > > As recently discussed on chromium-dev [1] and subsequently incorporated into the > Chromium Coding Style [2], NOTREACHED() followed by code is an anti-pattern. > This CL lets PRESUBMIT.py detect most of these cases and print a warning to the > developer. > [1] https://groups.google.com/a/chromium.org/d/msg/chromium-dev/c2X0D1Z6X2o/ddkFLqQP0P0J > [2] http://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED- > > BUG=none > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279681 TBR=maruel@chromium.org,tnagel@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279710

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -135 lines) Patch
M PRESUBMIT.py View 2 chunks +0 lines, -89 lines 0 comments Download
M PRESUBMIT_test.py View 1 chunk +0 lines, -46 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Miguel Garcia
Created Revert of Add PRESUBMIT.py warning for contradictory NOTREACHED() use.
6 years, 6 months ago (2014-06-25 14:07:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/357693004/1
6 years, 6 months ago (2014-06-25 14:09:11 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 14:10:34 UTC) #3
Message was sent while issue was closed.
Change committed as 279710

Powered by Google App Engine
This is Rietveld 408576698