Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 357673002: Do not pass additional TSan options when building and running TSan tests. (Closed)

Created:
6 years, 5 months ago by Alexander Potapenko
Modified:
6 years, 5 months ago
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Visibility:
Public.

Description

Do not pass additional TSan options when building and running TSan tests. These are now linked into the binaries themselves. BUG=302040 R=kjellander@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=280307

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -34 lines) Patch
M scripts/slave/compile.py View 2 chunks +0 lines, -16 lines 0 comments Download
M scripts/slave/runtest.py View 3 chunks +1 line, -18 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Alexander Potapenko
Henrik, can you please take a look and let me know if this works for ...
6 years, 5 months ago (2014-06-25 11:10:07 UTC) #1
kjellander_chromium
I need to migrate WebRTC to use the compiler-based suppressions before this can go in. ...
6 years, 5 months ago (2014-06-25 11:47:14 UTC) #2
kjellander_chromium
On 2014/06/25 11:47:14, kjellander wrote: > I need to migrate WebRTC to use the compiler-based ...
6 years, 5 months ago (2014-06-26 14:07:05 UTC) #3
kjellander (google.com)
Our CL is landed and recipes are updated. Feel free to commit this from WebRTC's ...
6 years, 5 months ago (2014-06-27 11:38:24 UTC) #4
kjellander_chromium
... and a lgtm with the right account.
6 years, 5 months ago (2014-06-27 11:38:53 UTC) #5
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 5 months ago (2014-06-27 11:50:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/357673002/1
6 years, 5 months ago (2014-06-27 11:51:02 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 11:52:10 UTC) #8
Message was sent while issue was closed.
Change committed as 280307

Powered by Google App Engine
This is Rietveld 408576698