Issue 357653003: Mark the single autofilled field when the relevant section is autofilled.

Issue 357653003: Mark the single autofilled field when the relevant section is autofilled. (Closed)

Created:
6 years, 6 months ago by ziran.sun

Modified:
6 years, 5 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mark the single autofilled field when the relevant section is autofilled.This allows the renderer to distinguish autofilled fields from fields with non-empty values, such as select-one fields. R=isherman@chromium.org BUG=388477 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280469

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update code as per Ilya's review comments. #

Total comments: 1

Patch Set 3 : Use iterator to point to the element rather than index. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -0 lines)			Patch
	M	chrome/browser/autofill/autofill_interactive_uitest.cc	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download
	M	components/autofill/core/browser/autofill_manager.cc	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

Thanks, Ziran! Could you please also add a test to cover this behavior to https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/autofill/autofill_interactive_uitest.cc ...

6 years, 6 months ago (2014-06-25 20:08:29 UTC) #2

ziran.sun

Update code as per review comments. Please review. Thanks!

6 years, 6 months ago (2014-06-26 17:08:14 UTC) #3

Ilya Sherman

https://codereview.chromium.org/357653003/diff/20001/components/autofill/core/browser/autofill_manager.cc File components/autofill/core/browser/autofill_manager.cc (right): https://codereview.chromium.org/357653003/diff/20001/components/autofill/core/browser/autofill_manager.cc#newcode576 components/autofill/core/browser/autofill_manager.cc:576: result.fields[index].is_autofilled = true; Why do you need an index? ...

6 years, 5 months ago (2014-06-27 05:59:08 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/357653003/40001

6 years, 5 months ago (2014-06-27 19:39:32 UTC) #8

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...

6 years, 5 months ago (2014-06-27 22:40:37 UTC) #9

Message was sent while issue was closed.

Change committed as 280469

Expand Messages | Collapse Messages