Issue 357643002: Set OS=android via GYP_DEFINES

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 357643002: Set OS=android via GYP_DEFINES (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 5 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Set OS=android via GYP_DEFINES Otherwise, the variable isn't available in all scopes. Instead of playing around with nested scopes, we just set it in GYP_DEFINES (same as chromium does) BUG=v8:3405 R=ulan@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=22004

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Makefile.android	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	build/android.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

jochen (gone - plz use gerrit)

6 years, 5 months ago (2014-06-25 09:48:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22004 (presubmit successful).