Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 35763004: [net] Move android/x509_util.[cc|h] to cert/x509_util_android.[cc|h] (Closed)

Created:
7 years, 2 months ago by nyquist
Modified:
7 years, 2 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

[net] Move android/x509_util.[cc|h] to cert/x509_util_android.[cc|h] Another x509_util.[cc|h] already exist, and the Android specific files where introduced in r230126. BUG=149426 R=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -51 lines) Patch
M net/android/net_jni_registrar.cc View 1 chunk +1 line, -1 line 0 comments Download
D net/android/x509_util.h View 1 chunk +0 lines, -16 lines 0 comments Download
D net/android/x509_util.cc View 1 chunk +0 lines, -25 lines 0 comments Download
A + net/cert/x509_util_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/cert/x509_util_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gyp View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/gn/secondary/net/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nyquist
rsleevi: PTAL
7 years, 2 months ago (2013-10-22 20:16:41 UTC) #1
Ryan Sleevi
lgtm
7 years, 2 months ago (2013-10-22 20:20:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/35763004/1
7 years, 2 months ago (2013-10-22 21:12:57 UTC) #3
nyquist
7 years, 2 months ago (2013-10-22 21:53:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r230218 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698