ui/events/keycodes/keyboard_code_conversion_x.h - Issue 357613002: Gets correct KeyboardCode from XEvent for non-US layouts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/keycodes/keyboard_code_conversion_x.h

Issue 357613002: Gets correct KeyboardCode from XEvent for non-US layouts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed test failures due to unsorted MAP1. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/events/keycodes/keyboard_code_conversion_x.h

diff --git a/ui/events/keycodes/keyboard_code_conversion_x.h b/ui/events/keycodes/keyboard_code_conversion_x.h

index ff34ba1358d21c49a69c00ea1181a7896a0e7691..9ea0ac2df390df5a3fbd58295476af89672b4733 100644

--- a/ui/events/keycodes/keyboard_code_conversion_x.h

+++ b/ui/events/keycodes/keyboard_code_conversion_x.h

@@ -26,9 +26,9 @@ EVENTS_BASE_EXPORT uint16 GetCharacterFromXEvent(XEvent* xev);

EVENTS_BASE_EXPORT int XKeysymForWindowsKeyCode(KeyboardCode keycode,

bool shift);

-// Converts an X keycode into an X KeySym.

-EVENTS_BASE_EXPORT unsigned int DefaultXKeysymFromHardwareKeycode(

- unsigned int keycode);

+// Converts an X keycode into ui::KeyboardCode.

+EVENTS_BASE_EXPORT KeyboardCode DefaultKeyboardCodeFromHardwareKeycode(

+ unsigned int hardware_code);

} // namespace ui

« no previous file with comments | « no previous file | ui/events/keycodes/keyboard_code_conversion_x.cc » ('j') | ui/events/keycodes/keyboard_code_conversion_x.cc » ('J')