Issue 357603005: Introduce debug events for promises.

Issue 357603005: Introduce debug events for promises. (Closed)

Created:
6 years, 6 months ago by Yang

Modified:
6 years, 5 months ago

Reviewers:
Alexandra Mikhaylova, aandrey, rossberg

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Introduce debug events for promises. R=aandrey@chromium.org, rossberg@chromium.org BUG=v8:3093 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=22086

Patch Set 2 : rebase and addressed comments #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -7 lines)			Patch
M	include/v8-debug.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/debug.h	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/debug.cc	View	1	2 chunks	+26 lines, -0 lines	0 comments	Download
M	src/debug-debugger.js	View	1	2 chunks	+28 lines, -1 line	0 comments	Download
M	src/promise.js	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/runtime.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
A	test/mjsunit/es6/debug-promises-new-event.js	View		1 chunk	+40 lines, -0 lines	0 comments	Download
A +	test/mjsunit/runtime-gen/debugpromiseevent.js	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/generate-runtime-tests.py	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Yang

On 2014/06/25 08:27:49, Yang wrote: > This is the first of many debug events for ...

6 years, 5 months ago (2014-06-26 14:21:11 UTC) #2

aandrey

lgtm https://codereview.chromium.org/357603005/diff/1/src/debug-debugger.js File src/debug-debugger.js (right): https://codereview.chromium.org/357603005/diff/1/src/debug-debugger.js#newcode1270 src/debug-debugger.js:1270: NewPromiseEvent.prototype.promise = PromiseGetter; inline PromiseGetter? https://codereview.chromium.org/357603005/diff/1/src/promise.js File src/promise.js ...

6 years, 5 months ago (2014-06-29 12:16:00 UTC) #3

Yang

https://codereview.chromium.org/357603005/diff/1/src/debug-debugger.js File src/debug-debugger.js (right): https://codereview.chromium.org/357603005/diff/1/src/debug-debugger.js#newcode1270 src/debug-debugger.js:1270: NewPromiseEvent.prototype.promise = PromiseGetter; On 2014/06/29 12:16:00, aandrey wrote: > ...

6 years, 5 months ago (2014-06-30 11:11:59 UTC) #5

Yang

6 years, 5 months ago (2014-06-30 11:12:54 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 manually as r22086 (presubmit successful).

Expand Messages | Collapse Messages