Add functions searching a word boundary without VisualPosition to HTMLTextFormControlElement.

Source/core/rendering/RenderTreeAsText.h

 /*
  * Copyright (C) 2003, 2006, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 19 matching lines @@
 #include "wtf/Forward.h"
 
 namespace WebCore {
 
 class Element;
 class LocalFrame;
 class LayoutRect;
 class RenderLayer;
 class RenderObject;
 class TextStream;
+class Node;

[Yuta Kitamura, 2014/07/03 08:39:27]

nit: Please arrange the forward declarations in the
alphabetical order. (Well, LocalFrame and LayoutRect
are not in the correct order, but I assume that's
just a mistake.)

[yoichio, 2014/07/04 01:29:44]

Done.

 
 enum RenderAsTextBehaviorFlags {
     RenderAsTextBehaviorNormal = 0,
     RenderAsTextShowAllLayers = 1 << 0, // Dump all layers, not just those that would paint.
     RenderAsTextShowLayerNesting = 1 << 1, // Annotate the layer lists.
     RenderAsTextShowCompositedLayers = 1 << 2, // Show which layers are composited.
     RenderAsTextShowAddresses = 1 << 3, // Show layer and renderer addresses.
     RenderAsTextShowIDAndClass = 1 << 4, // Show id and class attributes
     RenderAsTextPrintingMode = 1 << 5, // Dump the tree in printing mode.
     RenderAsTextDontUpdateLayout = 1 << 6, // Don't update layout, to make it safe to call showLayerTree() from the debugger inside layout or painting code.
@@ skipping 15 matching lines @@
 static void writeLayers(TextStream&, const RenderLayer* rootLayer, RenderLayer*, const LayoutRect& paintDirtyRect, int indent = 0, RenderAsTextBehavior = RenderAsTextBehaviorNormal);
 };
 
 // Helper function shared with SVGRenderTreeAsText
 String quoteAndEscapeNonPrintables(const String&);
 
 String counterValueForElement(Element*);
 
 String markerTextForListItem(Element*);
 
+String nodePosition(Node*);

[Yuta Kitamura, 2014/07/03 08:39:27]

Generally speaking, it is a bad idea to define a function
which has such a generic name in the namespace level scope.

I have several suggestions on naming:
* Please make sure the function returns a String describing
  the position, such as "nodePositionAsString".
* Please put "ForTesting" to the function name to make it
  clear that the function should only be used from tests.

[yoichio, 2014/07/04 01:29:44]

Done.

+
 } // namespace WebCore
 
 #endif // RenderTreeAsText_h