Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 357603002: split MEMORY_TOOL_REPLACES_ALLOCATOR into initial size and malloc. (Closed)

Created:
6 years, 6 months ago by JungJik
Modified:
6 years, 5 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

split MEMORY_TOOL_REPLACES_ALLOCATOR into initial size and malloc. currently all sanitizer use MEMORY_TOOL_REPLACES_ALLOCATOR defines for setting initial size and malloc allocation. However none memory sanitizer tools like deep-memory-profiler doesn't need to set initial size. This is a patch for splitting the define up into MEMORY_TOOL_REPLACES_ALLOCATOR, MEMORY_SANITIZER_INITIAL_SIZE. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177521

Patch Set 1 #

Patch Set 2 : use system_malloc optionally by gyp configuration #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/wtf/HashTraits.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/ListHashSet.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/Vector.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 31 (0 generated)
JungJik
PTAL :) current DMP doesn't show all objects(like tc-webcore) which are allocated by WTF_MAKE_FAST_ALLOCATED.
6 years, 6 months ago (2014-06-25 10:17:09 UTC) #1
esprehn
What does ENABLE_PROFILING mean? We build and profile all the time on linux and need ...
6 years, 6 months ago (2014-06-25 12:05:43 UTC) #2
JungJik
On 2014/06/25 12:05:43, esprehn wrote: > What does ENABLE_PROFILING mean? We build and profile all ...
6 years, 6 months ago (2014-06-25 12:48:18 UTC) #3
abarth-chromium
not lgtm We profile on Android all the time and we want to use the ...
6 years, 6 months ago (2014-06-25 19:26:08 UTC) #4
Dai Mikurube (NOT FULLTIME)
Yeah, I'm aware of the problem that PartitionAlloc is not captured by dmprof. I think ...
6 years, 6 months ago (2014-06-26 04:42:06 UTC) #5
JungJik
On 2014/06/26 04:42:06, Dai Mikurube wrote: > Yeah, I'm aware of the problem that PartitionAlloc ...
6 years, 6 months ago (2014-06-26 06:59:10 UTC) #6
Dai Mikurube (NOT FULLTIME)
I delegate final decision to abarth and/or other Blink professionals as I'm not very familiar ...
6 years, 6 months ago (2014-06-26 07:10:44 UTC) #7
abarth-chromium
> I've check the ENABLE_PROFILING on Android/ChromeShell/Release. > and it was disable by default at ...
6 years, 6 months ago (2014-06-26 07:26:24 UTC) #8
Dai Mikurube (NOT FULLTIME)
jfyi, a #define flag MEMORY_TOOL_REPLACES_ALLOCATOR disables PartitionAlloc in SOurce/wtf/PartitionAlloc.*. This flag is switched in Chromium's ...
6 years, 6 months ago (2014-06-26 07:41:04 UTC) #9
JungJik
On 2014/06/26 07:41:04, Dai Mikurube wrote: > jfyi, a #define flag MEMORY_TOOL_REPLACES_ALLOCATOR disables PartitionAlloc in ...
6 years, 6 months ago (2014-06-26 07:58:06 UTC) #10
Dai Mikurube (NOT FULLTIME)
On 2014/06/26 07:58:06, JungJik wrote: > On 2014/06/26 07:41:04, Dai Mikurube wrote: > > jfyi, ...
6 years, 6 months ago (2014-06-27 05:49:59 UTC) #11
JungJik
On 2014/06/27 05:49:59, Dai Mikurube wrote: > On 2014/06/26 07:58:06, JungJik wrote: > > On ...
6 years, 5 months ago (2014-06-30 02:31:47 UTC) #12
abarth-chromium
On 2014/06/30 at 02:31:47, jungjik.lee wrote: > if we can not use MEMORY_TOOL_REPLACES_ALLOCATOR, > can ...
6 years, 5 months ago (2014-06-30 02:43:11 UTC) #13
abarth-chromium
Removing WTF_USE_SYSTEM_MALLOC in https://codereview.chromium.org/345203007
6 years, 5 months ago (2014-06-30 02:47:58 UTC) #14
abarth-chromium
Can we split MEMORY_TOOL_REPACES_ALLOCATOR into two defines that are both controlled from GYP? One would ...
6 years, 5 months ago (2014-06-30 03:18:22 UTC) #15
JungJik
On 2014/06/30 03:18:22, abarth wrote: > Can we split MEMORY_TOOL_REPACES_ALLOCATOR into two defines that are ...
6 years, 5 months ago (2014-06-30 07:30:33 UTC) #16
abarth-chromium
On 2014/06/30 at 07:30:33, jungjik.lee wrote: > On 2014/06/30 03:18:22, abarth wrote: > > Can ...
6 years, 5 months ago (2014-06-30 17:31:05 UTC) #17
JungJik
On 2014/06/30 17:31:05, abarth wrote: > On 2014/06/30 at 07:30:33, jungjik.lee wrote: > > On ...
6 years, 5 months ago (2014-07-03 01:52:09 UTC) #18
abarth-chromium
lgtm
6 years, 5 months ago (2014-07-03 02:23:31 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/357603002/60001
6 years, 5 months ago (2014-07-03 02:24:42 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-03 03:34:33 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-03 04:26:35 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/28880)
6 years, 5 months ago (2014-07-03 04:26:36 UTC) #23
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 5 months ago (2014-07-03 06:33:38 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/357603002/60001
6 years, 5 months ago (2014-07-03 06:34:55 UTC) #25
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-03 08:31:24 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-03 09:48:25 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/15253)
6 years, 5 months ago (2014-07-03 09:48:25 UTC) #28
JungJik
The CQ bit was checked by jungjik.lee@samsung.com
6 years, 5 months ago (2014-07-04 07:05:49 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/357603002/60001
6 years, 5 months ago (2014-07-04 07:06:21 UTC) #30
commit-bot: I haz the power
6 years, 5 months ago (2014-07-04 08:12:57 UTC) #31
Message was sent while issue was closed.
Change committed as 177521

Powered by Google App Engine
This is Rietveld 408576698