Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 357583002: __FUNCTION__ cannot concatenate with constant strings in all compilers. (Closed)

Created:
6 years, 6 months ago by Nico
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

__FUNCTION__ cannot concatenate with constant strings in all compilers. According to http://www.delorie.com/gnu/docs/gcc/gcc_78.html (bottom), The identifier __FUNCTION__ is implicitly declared by the translator as if, immediately following the opening brace of each function definition, the declaration static const char __FUNCTION__[] = "function-name"; So use an explicit << instead of relying on string constant concatenation. BUG=82385 R=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M win8/test/open_with_dialog_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/test/ui_automation_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Nico
6 years, 6 months ago (2014-06-25 00:16:42 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
6 years, 6 months ago (2014-06-25 00:51:47 UTC) #2
Nico
Committed patchset #1 manually as r279564 (presubmit successful).
6 years, 6 months ago (2014-06-25 00:53:46 UTC) #3
grt (UTC plus 2)
ah, lgtm.
6 years, 6 months ago (2014-06-25 00:58:46 UTC) #4
wahyuterminator
6 years, 3 months ago (2014-09-05 21:42:18 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698