Issue 357513003: Stop using SpdySynStreamIR for SPDY 4.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 357513003: Stop using SpdySynStreamIR for SPDY 4. (Closed)

Created:
6 years, 6 months ago by Johnny

Modified:
6 years, 5 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Stop using SpdySynStreamIR for SPDY 4. This lands server change 69298498 by hkhalil. Also update SpdyTestUtil fixture utilities to appropriately select SpdySynStreamIR vs SpdyHeadersIR. Update tests use of fixtures as needed. BUG=

Patch Set 1 #

Patch Set 2 : WebSocket test fix. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+290 lines, -450 lines)			Patch
M	net/http/http_network_transaction_unittest.cc	View		5 chunks	+20 lines, -23 lines	0 comments	Download
M	net/spdy/buffered_spdy_framer_unittest.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	net/spdy/spdy_framer.cc	View		6 chunks	+15 lines, -47 lines	0 comments	Download
M	net/spdy/spdy_framer_test.cc	View		38 chunks	+122 lines, -193 lines	0 comments	Download
M	net/spdy/spdy_network_transaction_unittest.cc	View		9 chunks	+18 lines, -55 lines	0 comments	Download
M	net/spdy/spdy_proxy_client_socket_unittest.cc	View		3 chunks	+14 lines, -15 lines	0 comments	Download
M	net/spdy/spdy_session.cc	View		2 chunks	+27 lines, -11 lines	0 comments	Download
M	net/spdy/spdy_test_util_common.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	net/spdy/spdy_test_util_common.cc	View		7 chunks	+56 lines, -70 lines	0 comments	Download
M	net/spdy/spdy_websocket_test_util.cc	View	1	4 chunks	+5 lines, -36 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages