Issue 357483007: DevTools: [CodeMirror] add support for camel case movements.

Issue 357483007: DevTools: [CodeMirror] add support for camel case movements. (Closed)

Created:
6 years, 5 months ago by lushnikov

Modified:
6 years, 5 months ago

Reviewers:
vsevik, apavlov, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: [CodeMirror] add support for camel case movements. Camel-case movement allows movement between subwords of camel-case-written words or phrases. This patch adds support for camel-case movement to the DevTools editor. The camel-case movement is done via Alt-Left/Alt-Right on Win and Linux, and via Ctrl-Left/Ctrl-Right on Mac. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177099

Patch Set 1 #

Patch Set 2 : minor method renaming #

Total comments: 2

Patch Set 3 : use nice naming for shift-movement #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+638 lines, -4 lines)			Patch
M	LayoutTests/inspector/editor/text-editor-word-jumps.html	View		4 chunks	+40 lines, -1 line	0 comments	Download
M	LayoutTests/inspector/editor/text-editor-word-jumps-expected.txt	View		2 chunks	+402 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js	View	1 2	4 chunks	+178 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/ui/TextUtils.js	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

apavlov

I have never seen an IDE where Alt is used as a modifier for cursor ...

6 years, 5 months ago (2014-06-27 09:59:42 UTC) #2

lushnikov

On 2014/06/27 09:59:42, apavlov wrote: > I have never seen an IDE where Alt is ...

6 years, 5 months ago (2014-06-27 10:13:37 UTC) #3

vsevik

lgtm https://codereview.chromium.org/357483007/diff/20001/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js File Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js (right): https://codereview.chromium.org/357483007/diff/20001/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js#newcode88 Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js:88: "Shift-Alt-Left": "moveCamelLeftShift", consider selectCamelLeft

6 years, 5 months ago (2014-06-27 11:25:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/357483007/40001

6 years, 5 months ago (2014-06-27 11:58:16 UTC) #6

lushnikov

Thanks! https://codereview.chromium.org/357483007/diff/20001/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js File Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js (right): https://codereview.chromium.org/357483007/diff/20001/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js#newcode88 Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js:88: "Shift-Alt-Left": "moveCamelLeftShift", On 2014/06/27 11:25:43, vsevik wrote: > ...

6 years, 5 months ago (2014-06-27 11:58:23 UTC) #7

Message was sent while issue was closed.

Change committed as 177099

Expand Messages | Collapse Messages