Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: sdk/lib/_internal/pub/lib/src/source/path.dart

Issue 357483004: Split installing a package locally from symlinking to it. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revise! Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/source/git.dart ('k') | sdk/lib/_internal/pub/lib/src/source/unknown.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/source/path.dart
diff --git a/sdk/lib/_internal/pub/lib/src/source/path.dart b/sdk/lib/_internal/pub/lib/src/source/path.dart
index 4a92d770b7485159d8a00b082a32ba8089dcee37..808742ba5e558df836ebe4987e65d628d0d1c909 100644
--- a/sdk/lib/_internal/pub/lib/src/source/path.dart
+++ b/sdk/lib/_internal/pub/lib/src/source/path.dart
@@ -33,12 +33,13 @@ class PathSource extends Source {
return path1 == path2;
}
- /// Create a symlink from the source path directly to the destination
- /// directory.
- Future get(PackageId id, String destination) {
+ /// Path dependencies are already local.
+ Future ensureLocal(PackageId id) => new Future.value();
+
+ Future get(PackageId id, String symlink) {
return syncFuture(() {
var dir = _validatePath(id.name, id.description);
- createPackageSymlink(id.name, dir, destination,
+ createPackageSymlink(id.name, dir, symlink,
relative: id.description["relative"]);
});
}
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/source/git.dart ('k') | sdk/lib/_internal/pub/lib/src/source/unknown.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698