Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 357473002: Tidy up fOwner in SkMutex_pthread.h. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Tidy up fOwner in SkMutex_pthread.h. - Initialize fOwner to kNoOwner in SkMutex::SkMutex. - Note that we're stretching the API with kNoOwner. - Use pthread_equal() instead of ==. BUG=387993 Committed: https://skia.googlesource.com/skia/+/5a940b5cbb1320bffe7da37c07dcac84fb77fceb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M src/ports/SkMutex_pthread.h View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 6 months ago (2014-06-24 14:34:01 UTC) #1
hal.canary
LGTM
6 years, 6 months ago (2014-06-24 14:52:15 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-24 14:58:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/357473002/1
6 years, 6 months ago (2014-06-24 14:59:49 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 15:26:33 UTC) #5
Message was sent while issue was closed.
Change committed as 5a940b5cbb1320bffe7da37c07dcac84fb77fceb

Powered by Google App Engine
This is Rietveld 408576698