Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: src/isolate.cc

Issue 357453002: Revert assertion change from r21933 in Isolate::RunMicrotasks(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 89052139dfb598e9f2e3fc46b1998a7746f0ecbf..bc23df84b6d3519b92ae1b51b428d3f715eac279 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -2292,10 +2292,12 @@ void Isolate::EnqueueMicrotask(Handle<Object> microtask) {
void Isolate::RunMicrotasks() {
- // In some mjsunit tests %RunMicrotasks is called explicitly, violating
- // this assertion. Therefore we also check for --allow-natives-syntax.
- ASSERT(FLAG_allow_natives_syntax ||
- handle_scope_implementer()->CallDepthIsZero());
+ // TODO(adamk): This ASSERT triggers in mjsunit tests which
marja 2014/06/24 13:47:17 You might want to update this comment; afaics it n
+ // call the %RunMicrotasks runtime function. But it should
+ // never happen outside of tests, so it would be nice to
+ // uncomment it.
+ //
+ // ASSERT(handle_scope_implementer()->CallDepthIsZero());
// Increase call depth to prevent recursive callbacks.
v8::Isolate::SuppressMicrotaskExecutionScope suppress(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698