Issue 357453002: Revert assertion change from r21933 in Isolate::RunMicrotasks().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 357453002: Revert assertion change from r21933 in Isolate::RunMicrotasks(). (Closed)

Created:
6 years, 6 months ago by Yang

Modified:
6 years, 6 months ago

Reviewers:
marja

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Revert assertion change from r21933 in Isolate::RunMicrotasks(). R=marja@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21971

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	src/isolate.cc	View	1	1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

marja

lgtm https://codereview.chromium.org/357453002/diff/1/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/357453002/diff/1/src/isolate.cc#newcode2295 src/isolate.cc:2295: // TODO(adamk): This ASSERT triggers in mjsunit tests ...

6 years, 6 months ago (2014-06-24 13:47:17 UTC) #2

Yang

6 years, 6 months ago (2014-06-24 13:59:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21971 (presubmit successful).

Expand Messages | Collapse Messages

Issue 357453002: Revert assertion change from r21933 in Isolate::RunMicrotasks(). (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages