Source/bindings/scripts/v8_attributes.py - Issue 357413003: IDL: Drop redundant null check for string and wrapper type attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 357413003: IDL: Drop redundant null check for string and wrapper type attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_attributes.py

diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py

index c9d64402af6f4b457c2bf1ca0e35970a4825b631..363217e7f8a9f6174593895e1f5624f0a14190b6 100644

--- a/Source/bindings/scripts/v8_attributes.py

+++ b/Source/bindings/scripts/v8_attributes.py

@@ -170,7 +170,7 @@ def getter_context(interface, attribute, context):

# FIXME: check if compilers are smart enough to inline this, and if so,

# always use a local variable (for readability and CG simplicity).

release = False

- if (idl_type.is_nullable or

+ if ((idl_type.is_nullable and not context['is_nullable_simple']) or

base_idl_type == 'EventHandler' or

'CachedAttribute' in extended_attributes or

'ReflectOnly' in extended_attributes or

« no previous file with comments | « no previous file | Source/bindings/scripts/v8_types.py » ('j') | Source/bindings/scripts/v8_types.py » ('J')