Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: chrome/browser/media/media_browsertest.h

Issue 357413002: Have media content and chrome browser tests load data from media/test/data (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix net dependency for media_perftests Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/media_browsertest.h
diff --git a/chrome/browser/media/media_browsertest.h b/chrome/browser/media/media_browsertest.h
index be62f7a3cf954e9cead431a9bf3688aaf511f4bc..f1375cf66d2ac14fe8838a8645570a8cc826ecbf 100644
--- a/chrome/browser/media/media_browsertest.h
+++ b/chrome/browser/media/media_browsertest.h
@@ -10,6 +10,7 @@
#include "chrome/test/base/in_process_browser_test.h"
#include "content/public/browser/web_contents_observer.h"
+#include "media/base/test_data_util.h"
namespace content {
class TitleWatcher;
@@ -21,8 +22,6 @@ class TitleWatcher;
class MediaBrowserTest : public InProcessBrowserTest,
public content::WebContentsObserver {
protected:
- typedef std::pair<std::string, std::string> StringPair;
-
// Common test results.
static const char kEnded[];
// TODO(xhwang): Report detailed errors, e.g. "ERROR-3".
@@ -38,12 +37,13 @@ class MediaBrowserTest : public InProcessBrowserTest,
// page, otherwise a local file URL is loaded inside the content shell.
// It uses RunTest() to check for expected test output.
void RunMediaTestPage(const std::string& html_page,
- std::vector<StringPair>* query_params,
- const std::string& expected, bool http);
+ std::vector<media::StringPair>* query_params,
+ const std::string& expected,
+ bool http);
// Opens a URL and waits for the document title to match either one of the
// default strings or the expected string.
- base::string16 RunTest(const GURL& gurl, const std::string& expected);
+ std::string RunTest(const GURL& gurl, const std::string& expected);
xhwang 2014/07/07 17:39:54 Document about what the return value is.
shadi 2014/07/07 22:58:44 Done.
virtual void AddWaitForTitles(content::TitleWatcher* title_watcher);

Powered by Google App Engine
This is Rietveld 408576698