Have media content and chrome browser tests load data from media/test/data

content/browser/media/media_browsertest.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_MEDIA_MEDIA_BROWSERTEST_H_
 #define CONTENT_BROWSER_MEDIA_MEDIA_BROWSERTEST_H_
 
 #include <utility>
 #include <vector>
 
 #include "content/public/test/content_browser_test.h"
 
 namespace content {
 
 class TitleWatcher;
 
 // Class used to automate running media related browser tests. The functions
 // assume that media files are located under files/media/ folder known to
 // the test http server.
 class MediaBrowserTest : public ContentBrowserTest {
  public:
-  typedef std::pair<const char*, const char*> StringPair;
+  typedef std::pair<std::string, std::string> StringPair;
 
   // Common test results.
   static const char kEnded[];

[jrummell, 2014/07/02 00:33:40]

Should these be std::string since |expected| below is? Or is that not allowed
and we rely on the compiler creating the std::string as needed?

[shadi, 2014/07/02 19:23:36]

I believe I had this conversation with xhwang sometime ago, and the conclusion
was not to use static const for non-primitive types?
xhwang@: can you refresh my memory again? :)

   static const char kError[];
   static const char kFailed[];
 
   // Runs a html page with a list of URL query parameters.
   // If http is true, the test starts a local http test server to load the test
   // page, otherwise a local file URL is loaded inside the content shell.
   // It uses RunTest() to check for expected test output.
-  void RunMediaTestPage(const char* html_page,
+  void RunMediaTestPage(const std::string& html_page,
                         std::vector<StringPair>* query_params,
-                        const char* expected, bool http);
+                        const std::string& expected, bool http);
 
   // Opens a URL and waits for the document title to match either one of the
   // default strings or the expected string.
-  void RunTest(const GURL& gurl, const char* expected);
+  base::string16 RunTest(const GURL& gurl, const std::string& expected);

[jrummell, 2014/07/02 00:33:40]

Can the return value be std::string as well? I don't think we have any titles
used that aren't just ASCII characters. If you want, you could add a DCHECK in
the implementation that it is all ASCII values, just to be sure
(base::IsStringASCII()).

[shadi, 2014/07/02 19:23:36]

Yeah, I don't see a problem converting title watcher result to from string16 to
string. 

PS: there already exist a DCHECK in UTF16ToASCII() function to make sure it is
all ASCII.

 
   virtual void AddWaitForTitles(content::TitleWatcher* title_watcher);
 };
 
 } // namespace content
 
 #endif  // CONTENT_BROWSER_MEDIA_MEDIA_BROWSERTEST_H_