Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issue 357383003: Make JsNative1JsNative2JsSample cctest work on Win Release (Closed)

Created:
6 years, 5 months ago by alph
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Make JsNative1JsNative2JsSample cctest work on Win Release MSVC optimization realizes that CallJsFunction2 is just the same as CallJsFunction, so it eliminates the former making the call stack contain two instances of the same function. The patch makes two functions distinct. LOG=N BUG=v8:3055 R=aandrey@chromium.org, jkummerow@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22113

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M test/cctest/cctest.status View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
alph
6 years, 5 months ago (2014-06-30 17:23:54 UTC) #1
yurys
lgtm
6 years, 5 months ago (2014-07-01 05:31:32 UTC) #2
aandrey
lgtm https://codereview.chromium.org/357383003/diff/1/test/cctest/cctest.status File test/cctest/cctest.status (left): https://codereview.chromium.org/357383003/diff/1/test/cctest/cctest.status#oldcode155 test/cctest/cctest.status:155: # BUG(3055). BUG=3055 ?
6 years, 5 months ago (2014-07-01 08:20:42 UTC) #3
alph
Michael, could you please do the owners review.
6 years, 5 months ago (2014-07-01 09:16:03 UTC) #4
alph
https://codereview.chromium.org/357383003/diff/1/test/cctest/cctest.status File test/cctest/cctest.status (left): https://codereview.chromium.org/357383003/diff/1/test/cctest/cctest.status#oldcode155 test/cctest/cctest.status:155: # BUG(3055). On 2014/07/01 08:20:42, aandrey wrote: > BUG=3055 ...
6 years, 5 months ago (2014-07-01 09:17:08 UTC) #5
Jakob Kummerow
lgtm
6 years, 5 months ago (2014-07-01 09:46:19 UTC) #6
alph
Committed patchset #2 manually as r22113 (tree was closed).
6 years, 5 months ago (2014-07-01 10:10:22 UTC) #7
Michael Achenbach
Note that these trybot results are not showing anything. All CPU profiler test are marked ...
6 years, 5 months ago (2014-07-01 10:36:36 UTC) #8
alph
6 years, 5 months ago (2014-07-01 15:09:10 UTC) #9
Message was sent while issue was closed.
On 2014/07/01 10:36:36, Michael Achenbach wrote:
> Note that these trybot results are not showing anything. All CPU profiler test
> are marked as flaky in line 76 on all platforms. The try servers are not
running
> tests marked as flaky.

Oh, I see, thanks.
At least I can see it's fixed on the waterfall bots, e.g.
http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%201 in #2068

Powered by Google App Engine
This is Rietveld 408576698