Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 357323003: Linux sandbox: add space for 8 parameters to the Syscall() class (Closed)

Created:
6 years, 5 months ago by nedeljko
Modified:
6 years, 5 months ago
Reviewers:
mdempsky
CC:
chromium-reviews, agl, jln+watch_chromium.org, jln (very slow on Chromium), petar.jovanovic
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Linux sandbox: add space for 8 parameters to the Syscall() class On some architectures (Mips for example) syscalls can take more than six parameters. Add support for 8 native-size parameters in Syscall::Call() BUG=369594 TEST= sandbox_linux_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281823

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update per code review #

Total comments: 2

Patch Set 3 : Remove leading colon from the error message string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -23 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf/syscall.h View 3 chunks +70 lines, -22 lines 0 comments Download
M sandbox/linux/seccomp-bpf/syscall.cc View 1 2 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
nedeljko
I made support for up to 8 arguments in Syscall() structure as requested in: https://codereview.chromium.org/260793003/ ...
6 years, 5 months ago (2014-06-30 14:49:37 UTC) #1
mdempsky
On 2014/06/30 14:49:37, nedeljko wrote: > On the other hand, I was looking in kernel ...
6 years, 5 months ago (2014-07-01 21:53:17 UTC) #2
nedeljko
On 2014/07/01 21:53:17, mdempsky wrote: > > https://codereview.chromium.org/357323003/diff/1/sandbox/linux/seccomp-bpf/syscall.cc#newcode197 > sandbox/linux/seccomp-bpf/syscall.cc:197: // TODO(nedeljko): Enable use of ...
6 years, 5 months ago (2014-07-02 10:45:18 UTC) #3
nedeljko
https://codereview.chromium.org/357323003/diff/1/sandbox/linux/seccomp-bpf/syscall.cc File sandbox/linux/seccomp-bpf/syscall.cc (right): https://codereview.chromium.org/357323003/diff/1/sandbox/linux/seccomp-bpf/syscall.cc#newcode197 sandbox/linux/seccomp-bpf/syscall.cc:197: // TODO(nedeljko): Enable use of more than six parameters ...
6 years, 5 months ago (2014-07-02 10:46:19 UTC) #4
nedeljko
Ping. Should I make some additional changes for this CL to be accepted? Thanks.
6 years, 5 months ago (2014-07-07 09:51:08 UTC) #5
mdempsky
LGTM On 2014/07/07 09:51:08, nedeljko wrote: > Ping. (Sorry, I was on vacation for July ...
6 years, 5 months ago (2014-07-07 21:56:05 UTC) #6
nedeljko
https://codereview.chromium.org/357323003/diff/20001/sandbox/linux/seccomp-bpf/syscall.cc File sandbox/linux/seccomp-bpf/syscall.cc (right): https://codereview.chromium.org/357323003/diff/20001/sandbox/linux/seccomp-bpf/syscall.cc#newcode200 sandbox/linux/seccomp-bpf/syscall.cc:200: DCHECK_EQ(p6, 0) << ": Support for syscalls with more ...
6 years, 5 months ago (2014-07-08 13:56:08 UTC) #7
nedeljko
The CQ bit was checked by nedeljko.babic@imgtec.com
6 years, 5 months ago (2014-07-08 13:56:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nedeljko.babic@imgtec.com/357323003/40001
6 years, 5 months ago (2014-07-08 13:58:13 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 16:25:08 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 16:28:18 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/78520)
6 years, 5 months ago (2014-07-08 16:28:19 UTC) #12
mdempsky
The CQ bit was checked by mdempsky@chromium.org
6 years, 5 months ago (2014-07-08 19:01:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nedeljko.babic@imgtec.com/357323003/40001
6 years, 5 months ago (2014-07-08 19:02:43 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 21:00:19 UTC) #15
Message was sent while issue was closed.
Change committed as 281823

Powered by Google App Engine
This is Rietveld 408576698