Tray elements behave appropriately on the multiple signin screen (more like lock screen)

ash/system/bluetooth/tray_bluetooth.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/bluetooth/tray_bluetooth.h"
 
+#include "ash/session/session_state_delegate.h"
 #include "ash/shell.h"
 #include "ash/system/tray/fixed_sized_scroll_view.h"
 #include "ash/system/tray/hover_highlight_view.h"
 #include "ash/system/tray/system_tray.h"
 #include "ash/system/tray/system_tray_delegate.h"
 #include "ash/system/tray/system_tray_notifier.h"
 #include "ash/system/tray/throbber_view.h"
 #include "ash/system/tray/tray_constants.h"
 #include "ash/system/tray/tray_details_view.h"
 #include "ash/system/tray/tray_item_more.h"
@@ skipping 277 matching lines @@
 
   // Add settings entries.
   void AppendSettingsEntries() {
     if (!ash::Shell::GetInstance()->
             system_tray_delegate()->ShouldShowSettings()) {
       return;
     }
 
     // Add bluetooth device requires a browser window, hide it for non logged in
     // user.
-    if (login_ == user::LOGGED_IN_NONE || login_ == user::LOGGED_IN_LOCKED)
+    if (login_ == user::LOGGED_IN_NONE || login_ == user::LOGGED_IN_LOCKED ||
+        ash::Shell::GetInstance()
+                ->session_state_delegate()
+                ->GetSessionState() ==
+            ash::SessionStateDelegate::SESSION_STATE_LOGIN_SECONDARY)

[oshima, 2014/07/31 18:28:31]

Am I correct that many checks are basically "if a user is primary, unlocked"? If
so, can you add a predicate method in Shell and use it instead of repeating this
everywhere?

[Roman Sorokin (ftl), 2014/07/31 18:51:32]

This method does exist (IsUserSessionBlocked) but if we use it we completely
ignore LoginStatus param from CreateDefaultView. This is a case of changing
LoginStatus
https://code.google.com/p/chromium/codesearch#chromium/src/ash/system/tray/sy....
And there is a test for it.

       return;

[oshima, 2014/07/31 18:28:31]

you need {} in this case

 
     ash::SystemTrayDelegate* delegate =
         ash::Shell::GetInstance()->system_tray_delegate();
     ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
     HoverHighlightView* container = new HoverHighlightView(this);
     container->AddLabel(
         rb.GetLocalizedString(IDS_ASH_STATUS_TRAY_BLUETOOTH_MANAGE_DEVICES),
         gfx::ALIGN_LEFT,
         gfx::Font::NORMAL);
     container->SetEnabled(delegate->GetBluetoothAvailable());
@@ skipping 145 matching lines @@
     detailed_->Update();
 }
 
 void TrayBluetooth::OnBluetoothDiscoveringChanged() {
   if (!detailed_)
     return;
   detailed_->Update();
 }
 
 }  // namespace ash