Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 3573008: Merge 68446 - WebCore: ImageDecoderSkia.cpp needs to check for allocator fail... (Closed)

Created:
9 years, 6 months ago by inferno
Modified:
8 years, 11 months ago
Reviewers:
inferno
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/517/
Visibility:
Public.

Description

Merge 68446 - WebCore: ImageDecoderSkia.cpp needs to check for allocator failure when copying bitmaps. https://bugs.webkit.org/show_bug.cgi?id=46437 Reviewed by James Robinson. * manual-tests/large-size-image-crash.html: Added. * manual-tests/resources/large-size-image-crash.gif: Added. * platform/image-decoders/ImageDecoder.cpp: (WebCore::RGBA32Buffer::copyBitmapData): * platform/image-decoders/ImageDecoder.h: * platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::initFrameBuffer): * platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::copyBitmapData): * platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::RGBA32Buffer::copyBitmapData): LayoutTests: This resource should have been in r62399; without it the test no-ops. https://bugs.webkit.org/show_bug.cgi?id=41487 Reviewed by James Robinson. * fast/images/resources/large-size-image-crash.jpeg: Added. BUG=54500 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
A + LayoutTests/fast/images/resources/large-size-image-crash.jpeg View 0 chunks +-1 lines, --1 lines 0 comments Download
A + WebCore/manual-tests/large-size-image-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + WebCore/manual-tests/resources/large-size-image-crash.gif View 0 chunks +-1 lines, --1 lines 0 comments Download
M WebCore/platform/image-decoders/ImageDecoder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M WebCore/platform/image-decoders/ImageDecoder.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M WebCore/platform/image-decoders/qt/RGBA32BufferQt.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M WebCore/platform/image-decoders/skia/ImageDecoderSkia.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
inferno
9 years, 6 months ago (2010-10-04 20:01:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698