dmichael (off chromium)
2014/07/07 17:03:34
nit: It would be good to add
private:
DISALLOW_
nit: It would be good to add
private:
DISALLOW_COPY_AND_ASSIGN(PpapiPreferencesBuilder());
...to prevent misuse, since it appears there's no reason to construct one. That
not only takes care of copy and assign, but also implicitly ensures the compiler
won't give us a default constructor.
tfarina
2014/07/15 00:47:32
I will address this separately. None of the builde
On 2014/07/07 17:03:34, dmichael wrote:
> nit: It would be good to add
> private:
> DISALLOW_COPY_AND_ASSIGN(PpapiPreferencesBuilder());
>
> ...to prevent misuse, since it appears there's no reason to construct one.
That
> not only takes care of copy and assign, but also implicitly ensures the
compiler
> won't give us a default constructor.
I will address this separately. None of the builder.h files in content/ were
using DISALLOW_IMPLICIT_CONSTRUCTORS.
So I will make a patch to make all of them use DISALLOW_IMPLICIT_CONSTRUCTORS.
Issue 357203003: Move webpreferences.* from webkit/ to content/
(Closed)
Created 6 years, 5 months ago by tfarina
Modified 6 years, 5 months ago
Reviewers: jam, boliu, Bernhard Bauer, dmichael (off chromium)
Base URL: svn://svn.chromium.org/chrome/trunk/src
Comments: 16