Move webpreferences.* from webkit/ to content/

content/public/renderer/render_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_RENDER_VIEW_H_
 #define CONTENT_PUBLIC_RENDERER_RENDER_VIEW_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/strings/string16.h"
 #include "content/common/content_export.h"
 #include "content/public/common/top_controls_state.h"
 #include "ipc/ipc_sender.h"
 #include "third_party/WebKit/public/web/WebPageVisibilityState.h"
 #include "ui/gfx/native_widget_types.h"
 
-struct WebPreferences;
-
 namespace blink {
 class WebElement;
 class WebFrame;
 class WebLocalFrame;
 class WebNode;
 class WebString;
 class WebURLRequest;
 class WebView;
 struct WebContextMenuData;
 }
 
 namespace gfx {
 class Size;
 }
 
 namespace content {
 
 class RenderFrame;
 class RenderViewVisitor;
 struct SSLStatus;
+struct WebPreferences;
 
 class CONTENT_EXPORT RenderView : public IPC::Sender {
  public:
   // Returns the RenderView containing the given WebView.
   static RenderView* FromWebView(blink::WebView* webview);
 
   // Returns the RenderView for the given routing ID.
   static RenderView* FromRoutingID(int routing_id);
 
   // Visit all RenderViews with a live WebView (i.e., RenderViews that have
@@ skipping 17 matching lines @@
   // Returns the size of the view.
   virtual gfx::Size GetSize() const = 0;
 
   // Gets WebKit related preferences associated with this view.
   virtual WebPreferences& GetWebkitPreferences() = 0;
 
   // Overrides the WebKit related preferences associated with this view. Note
   // that the browser process may update the preferences at any time.
   virtual void SetWebkitPreferences(const WebPreferences& preferences) = 0;
 
+  virtual void ApplyWebPreferences(const WebPreferences& preferences) = 0;

[jam, 2014/07/02 18:33:23]

nit: please add a comment here

actually I had forgotten about SetWebKitPreferences. I wonder if we really need
both of these methods? It would be great in a followup to try to hide Apply in
the impl only, and to have external callers call Set only.

[tfarina, 2014/07/02 23:57:36]

Done.

+
   // Returns the associated WebView. May return NULL when the view is closing.
   virtual blink::WebView* GetWebView() = 0;
 
   // Gets the focused element. If no such element exists then
   // the element will be Null.
   virtual blink::WebElement GetFocusedElement() const = 0;
 
   // Returns true if the parameter node is a textfield, text area, a content
   // editable div, or has an ARIA role of textbox.
   virtual bool IsEditableNode(const blink::WebNode& node) const = 0;
@@ skipping 45 matching lines @@
 
  private:
   // This interface should only be implemented inside content.
   friend class RenderViewImpl;
   RenderView() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_RENDER_VIEW_H_