Domain Reliability: Add rudimentary WebUI page.

components/domain_reliability/service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/domain_reliability/service.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/single_thread_task_runner.h"
 #include "components/domain_reliability/monitor.h"
 #include "net/url_request/url_request_context_getter.h"
 
 namespace domain_reliability {
 
+namespace {
+
+void GetWebUIDataOnNetworkTaskRunner(
+    base::WeakPtr<DomainReliabilityMonitor> monitor,
+    scoped_ptr<const base::Value>* data_out) {
+  if (monitor)
+    *data_out = monitor->GetWebUIData();
+}
+
+void CallGetWebUIDataCallbackAndDeleteDataPointer(
+    const base::Callback<void(scoped_ptr<const base::Value>)>& callback,
+    scoped_ptr<const base::Value>* data_in) {
+  callback.Run(data_in->Pass());
+  delete data_in;
+}
+
+}  // namespace
+
 class DomainReliabilityServiceImpl : public DomainReliabilityService {
  public:
   explicit DomainReliabilityServiceImpl(
       const std::string& upload_reporter_string)
       : upload_reporter_string_(upload_reporter_string) {}
 
   virtual ~DomainReliabilityServiceImpl() {}
 
   // DomainReliabilityService implementation:
 
@@ skipping 15 matching lines @@
     DCHECK(network_task_runner_);
 
     network_task_runner_->PostTaskAndReply(
         FROM_HERE,
         base::Bind(&DomainReliabilityMonitor::ClearBrowsingData,
                    monitor_,
                    clear_mode),
         callback);
   }
 
+  virtual void GetWebUIData(
+      const base::Callback<void(scoped_ptr<const base::Value>)>& callback)
+      const OVERRIDE {
+    DCHECK(network_task_runner_);
+
+    scoped_ptr<const base::Value>* data =
+        new scoped_ptr<const base::Value>(new base::DictionaryValue());
+    network_task_runner_->PostTaskAndReply(FROM_HERE,

[Bernhard Bauer, 2014/06/28 11:16:35]

I think you can do this with base::PostTaskAndReplyWithResult(). And you can
directly pass a scoped_ptr to a callback with base::Passed().

[Deprecated (see juliatuttle), 2014/06/30 16:58:21]

Nah, I can't; it won't let me bind a weak pointer to GetWebUIData, since it has
a non-void return type, so I'd still need at least one wrapper function.

[Bernhard Bauer, 2014/06/30 17:26:54]

:-( Could you write a wrapper function like this:

  scoped_ptr<Value> GetWebUIData(WeakPtr<...> monitor) {
    if (!monitor)
      return NULL;

    return monitor->GetWebUIData();
  }

? That would at least get rid of the second wrapper function, and I think it
reads a bit more intuitively.

+        base::Bind(&GetWebUIDataOnNetworkTaskRunner,
+                   monitor_,
+                   data),
+        base::Bind(&CallGetWebUIDataCallbackAndDeleteDataPointer,
+                   callback,
+                   data));
+  }
+
  private:
   std::string upload_reporter_string_;
   base::WeakPtr<DomainReliabilityMonitor> monitor_;
   scoped_refptr<base::SequencedTaskRunner> network_task_runner_;
 };
 
 // static
 DomainReliabilityService* DomainReliabilityService::Create(
     const std::string& upload_reporter_string) {
   return new DomainReliabilityServiceImpl(upload_reporter_string);
 }
 
 DomainReliabilityService::~DomainReliabilityService() {}
 
 DomainReliabilityService::DomainReliabilityService() {}
 
 }  // namespace domain_reliability