Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 357033002: Remove attributeCount() / attributeAt() API from Element (Closed)

Created:
6 years, 5 months ago by Inactive
Modified:
6 years, 5 months ago
Reviewers:
esprehn, adamk
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, rwlbuis, sergeyv+blink_chromium.org, sof, vsevik+blink_chromium.org, yurys+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove attributeCount() / attributeAt() API from Element Remove attributeCount() / attributeAt() API from Element and port callers to the new AttributeCollection API instead. This avoids API duplication between Element and AttributeCollection. This also usually makes the calling code more efficient as it avoids redundant (implicit) ElementData::isUnique() checks and potentially leverages iterators. R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178056

Patch Set 1 #

Patch Set 2 : Clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -35 lines) Patch
M Source/core/dom/Element.h View 1 3 chunks +7 lines, -15 lines 0 comments Download
M Source/core/dom/Element.cpp View 4 chunks +10 lines, -8 lines 0 comments Download
M Source/core/dom/NamedNodeMap.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/DOMPatchSupport.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Inactive
6 years, 5 months ago (2014-06-27 18:16:18 UTC) #1
Inactive
6 years, 5 months ago (2014-07-01 12:15:00 UTC) #2
Inactive
Post-holiday ping :)
6 years, 5 months ago (2014-07-09 12:30:44 UTC) #3
esprehn
lgtm
6 years, 5 months ago (2014-07-14 08:41:33 UTC) #4
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 5 months ago (2014-07-14 13:22:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/357033002/20001
6 years, 5 months ago (2014-07-14 13:22:29 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 14:09:02 UTC) #7
Message was sent while issue was closed.
Change committed as 178056

Powered by Google App Engine
This is Rietveld 408576698