Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 357023002: Remove setting an empty origin header in FrameFetchContext (Closed)

Created:
6 years, 5 months ago by clamy
Modified:
6 years, 5 months ago
Reviewers:
Nate Chapin, ppi
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove setting an empty origin header in FrameFetchContext This is now done in RenderFrameImpl::willSendRequest. BUG=376025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M Source/core/loader/FrameFetchContext.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
clamy
@japhet, ppi: PTAL - this is a followup on https://chromiumcodereview.appspot.com/343273005/
6 years, 5 months ago (2014-06-27 13:29:07 UTC) #1
ppi
lgtm, thanks!
6 years, 5 months ago (2014-06-27 13:31:29 UTC) #2
Nate Chapin
lgtm
6 years, 5 months ago (2014-07-01 19:10:36 UTC) #3
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 5 months ago (2014-07-02 09:12:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/357023002/1
6 years, 5 months ago (2014-07-02 09:13:29 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-02 10:39:49 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-02 11:13:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/15043)
6 years, 5 months ago (2014-07-02 11:13:45 UTC) #8
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 5 months ago (2014-07-02 16:20:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/357023002/1
6 years, 5 months ago (2014-07-02 16:20:30 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 17:12:29 UTC) #11
Message was sent while issue was closed. 
Change committed as 177402

Powered by Google App Engine
This is Rietveld 408576698