Introduce enable_web_speech to replace with input_speech

Introduce enable_web_speech to replace with input_speech

Before this CL, implementation manipulated os condition
but that seemed not so straight forward.
Therefore, this CL introduced feature wise variable
so that later any os can easily enable/disable.

BUG=223198
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280972

[kangil_, 2014-06-30 10:30:42]

Trybot failures seem not to be related to this patch.
PTAL.

[brettw, 2014-06-30 17:12:16]

On 2014/06/30 10:30:42, kangil_ wrote:
> Trybot failures seem not to be related to this patch.
> PTAL.

This maps to enable_speech_input in the GN build. Looks like it's only reference
in two places:
build/config/features.gni
content/browser/BUILD.gn

Can you update those as well?

[lgombos, 2014-07-01 04:06:50]

> So this CL removes input_speech variable and replaces it with os conditions...

In general I thought that we have preference to go in the opposite direction and
instead of spreading the ('OS=="android" or OS=="ios"') condition into various
layers (e.g. content/ chrome/) we should instead have a variable that is set
based on the os condition.

This is also what we do in blink, see for example the following in config.h

#if OS(LINUX) || OS(ANDROID) || OS(WIN)
#define WTF_USE_HARFBUZZ 1
#endif

Another example from chromium (build/common.gypi)

        ['OS=="android"', {
          'enable_webrtc%': 1,
        }],

[kangil_, 2014-07-01 04:33:50]

On 2014/06/30 17:12:16, brettw wrote:
> On 2014/06/30 10:30:42, kangil_ wrote:
> > Trybot failures seem not to be related to this patch.
> > PTAL.
> 
> This maps to enable_speech_input in the GN build. Looks like it's only
reference
> in two places:
> build/config/features.gni
> content/browser/BUILD.gn
> 
> Can you update those as well?

Done.(trybot failures seem not to be related)
PTAL!

[kangil_, 2014-07-01 04:38:58]

On 2014/07/01 04:06:50, lgombos wrote:
> > So this CL removes input_speech variable and replaces it with os
conditions...
> 
> In general I thought that we have preference to go in the opposite direction
and
> instead of spreading the ('OS=="android" or OS=="ios"') condition into various
> layers (e.g. content/ chrome/) we should instead have a variable that is set
> based on the os condition.
> 
> This is also what we do in blink, see for example the following in config.h
> 
> #if OS(LINUX) || OS(ANDROID) || OS(WIN)
> #define WTF_USE_HARFBUZZ 1
> #endif
> 
> Another example from chromium (build/common.gypi)
> 
>         ['OS=="android"', {
>           'enable_webrtc%': 1,
>         }],

Thanks for the comment.
But, this patch is not related to implementation but clean up for deprecated
code.

[kangil_, 2014-07-01 05:00:14]

On 2014/07/01 04:38:58, kangil_ wrote:
> On 2014/07/01 04:06:50, lgombos wrote:
> > > So this CL removes input_speech variable and replaces it with os
> conditions...
> > 
> > In general I thought that we have preference to go in the opposite direction
> and
> > instead of spreading the ('OS=="android" or OS=="ios"') condition into
various
> > layers (e.g. content/ chrome/) we should instead have a variable that is set
> > based on the os condition.
> > 
> > This is also what we do in blink, see for example the following in config.h
> > 
> > #if OS(LINUX) || OS(ANDROID) || OS(WIN)
> > #define WTF_USE_HARFBUZZ 1
> > #endif
> > 
> > Another example from chromium (build/common.gypi)
> > 
> >         ['OS=="android"', {
> >           'enable_webrtc%': 1,
> >         }],
> 
> Thanks for the comment.
> But, this patch is not related to implementation but clean up for deprecated
> code.

Alright, android and ios clearly don't use web speech.
I will try to this way in this CL.
Replace input_speech with enable_web_speech.
Be back soon.

[kangil_, 2014-07-01 10:56:19]

PTAL

[brettw, 2014-07-02 00:38:12]

lgtm

[kangil_, 2014-07-02 00:41:55]

The CQ bit was checked by kangil.han@samsung.com

[commit-bot: I haz the power, 2014-07-02 00:43:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kangil.han@samsung.com/356963003/70001

[commit-bot: I haz the power, 2014-07-02 03:58:30]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-07-02 07:38:26]

Change committed as 280972