Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 356963003: Introduce enable_web_speech to replace with input_speech (Closed)

Created:
6 years, 5 months ago by kangil_
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Introduce enable_web_speech to replace with input_speech Before this CL, implementation manipulated os condition but that seemed not so straight forward. Therefore, this CL introduced feature wise variable so that later any os can easily enable/disable. BUG=223198 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280972

Patch Set 1 #

Patch Set 2 : Update patch as per review comment #

Patch Set 3 : Learning gn build #

Patch Set 4 : Introduce enable_web_speech to replace with input_speech #

Patch Set 5 : Fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -23 lines) Patch
M build/common.gypi View 1 2 3 4 chunks +5 lines, -7 lines 0 comments Download
M build/config/features.gni View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 3 4 2 chunks +10 lines, -6 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
kangil_
Trybot failures seem not to be related to this patch. PTAL.
6 years, 5 months ago (2014-06-30 10:30:42 UTC) #1
brettw
On 2014/06/30 10:30:42, kangil_ wrote: > Trybot failures seem not to be related to this ...
6 years, 5 months ago (2014-06-30 17:12:16 UTC) #2
lgombos
> So this CL removes input_speech variable and replaces it with os conditions... In general ...
6 years, 5 months ago (2014-07-01 04:06:50 UTC) #3
kangil_
On 2014/06/30 17:12:16, brettw wrote: > On 2014/06/30 10:30:42, kangil_ wrote: > > Trybot failures ...
6 years, 5 months ago (2014-07-01 04:33:50 UTC) #4
kangil_
On 2014/07/01 04:06:50, lgombos wrote: > > So this CL removes input_speech variable and replaces ...
6 years, 5 months ago (2014-07-01 04:38:58 UTC) #5
kangil_
On 2014/07/01 04:38:58, kangil_ wrote: > On 2014/07/01 04:06:50, lgombos wrote: > > > So ...
6 years, 5 months ago (2014-07-01 05:00:14 UTC) #6
kangil_
PTAL
6 years, 5 months ago (2014-07-01 10:56:19 UTC) #7
brettw
lgtm
6 years, 5 months ago (2014-07-02 00:38:12 UTC) #8
kangil_
The CQ bit was checked by kangil.han@samsung.com
6 years, 5 months ago (2014-07-02 00:41:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/356963003/70001
6 years, 5 months ago (2014-07-02 00:43:37 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-02 03:58:30 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 07:38:26 UTC) #12
Message was sent while issue was closed.
Change committed as 280972

Powered by Google App Engine
This is Rietveld 408576698