Adding DiskBasedCertCache to HttpCache (+UMA).

net/http/http_cache_transaction.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file declares HttpCache::Transaction, a private class of HttpCache so
 // it should only be included by http_cache.cc
 
 #ifndef NET_HTTP_HTTP_CACHE_TRANSACTION_H_
 #define NET_HTTP_HTTP_CACHE_TRANSACTION_H_
 
@@ skipping 414 matching lines @@
   bool bypass_lock_for_test_;  // A test is exercising the cache lock.
   scoped_refptr<IOBuffer> read_buf_;
   int io_buf_len_;
   int read_offset_;
   int effective_load_flags_;
   int write_len_;
   scoped_ptr<PartialData> partial_;  // We are dealing with range requests.
   UploadProgress final_upload_progress_;
   base::WeakPtrFactory<Transaction> weak_factory_;
   CompletionCallback io_callback_;
+  DiskBasedCertCache::GetCallback cert_read_io_callback_;
+  DiskBasedCertCache::SetCallback cert_write_io_callback_;

[Ryan Sleevi, 2014/06/26 19:56:02]

You don't need to store these callbacks as member variables.

Just base::Bind() on the fly. It's generally recommended not to save callbacks,
except for 'special' cases.

 
   // Members used to track data for histograms.
   TransactionPattern transaction_pattern_;
   base::TimeTicks entry_lock_waiting_since_;
   base::TimeTicks first_cache_access_since_;
   base::TimeTicks send_request_since_;
 
   int64 total_received_bytes_;
 
   // Load timing information for the last network request, if any.  Set in the
@@ skipping 10 matching lines @@
 
   BeforeNetworkStartCallback before_network_start_callback_;
   BeforeProxyHeadersSentCallback before_proxy_headers_sent_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(Transaction);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_CACHE_TRANSACTION_H_