Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 356933002: Introduce FullscreenElementStack::RequestType (Closed)

Created:
6 years, 6 months ago by philipj_slow
Modified:
6 years, 6 months ago
CC:
blink-reviews, philipj_slow, feature-media-reviews_chromium.org, gasubic, sof, eae+blinkwatch, fs, eric.carlson_apple.com, vcarbune.chromium, blink-reviews-dom_chromium.org, dglazkov+blink, nessy, blink-reviews-html_chromium.org, rwlbuis
Project:
blink
Visibility:
Public.

Description

Introduce FullscreenElementStack::RequestType This replaces flags + FullScreenCheckType, for a few reasons: 1. An UnprefixedRequest will be added, for which neither ALLOW_KEYBOARD_INPUT nor FullScreenCheckType is possible. Not all previously possible combinations are possible, either. 2. An enum is clearer than flags at the call site. In particular, 0 was passed to HTMLMediaElement::enterFullscreen() which would disallow keyboard input, which was not obivous and possibly not even the original intention. The behavior was preserved but should probably be changed to allow keyboard input in a future patch. 3. LEGACY_MOZILLA_REQUEST as a public part of Element.h is weird. BUG=383813 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177061

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -19 lines) Patch
M Source/core/dom/Element.h View 1 chunk +6 lines, -8 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +7 lines, -2 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.h View 1 chunk +6 lines, -4 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
PTAL. Note that this depends on https://codereview.chromium.org/339903005/ to land first, so no try bots yet. ...
6 years, 6 months ago (2014-06-26 15:08:09 UTC) #1
davve
Non-owner LGTM
6 years, 6 months ago (2014-06-26 15:11:25 UTC) #2
falken
the code is much easier to understand now! lgtm
6 years, 6 months ago (2014-06-27 01:00:51 UTC) #3
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 6 months ago (2014-06-27 02:29:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/356933002/1
6 years, 6 months ago (2014-06-27 02:30:07 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-27 04:16:08 UTC) #6
Message was sent while issue was closed.
Change committed as 177061

Powered by Google App Engine
This is Rietveld 408576698