Issue 35693009: Move Navigation.MainFrameScheme UMA recording to //components.

Issue 35693009: Move Navigation.MainFrameScheme UMA recording to //components. (Closed)

Created:
7 years, 2 months ago by cbentzel

Modified:
7 years, 2 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Move Navigation.MainFrameScheme UMA recording to //components. This change is simply a refactoring, and does not change behavior. BUG=299173 TEST=Run chromium, check about:histograms and make sure that Navigation.MainFrameScheme matches expectations. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230508

Patch Set 1 #

Total comments: 5

Patch Set 2 : Address review comments. #

Patch Set 3 : Address review comments. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -50 lines)			Patch
M	chrome/browser/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/navigation_metrics_recorder.cc	View		3 chunks	+2 lines, -47 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/components.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	components/navigation_metrics.gypi	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
A	components/navigation_metrics/navigation_metrics.h	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
A	components/navigation_metrics/navigation_metrics.cc	View	1	1 chunk	+57 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

cbentzel

https://codereview.chromium.org/35693009/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://codereview.chromium.org/35693009/diff/1/chrome/chrome_browser.gypi#newcode31 chrome/chrome_browser.gypi:31: '../components/components.gyp:navigation_metrics', I will be using this for iOS (that's ...

7 years, 2 months ago (2013-10-23 14:29:28 UTC) #1

jochen (gone - plz use gerrit)

lgtm https://codereview.chromium.org/35693009/diff/1/components/navigation_metrics.gypi File components/navigation_metrics.gypi (right): https://codereview.chromium.org/35693009/diff/1/components/navigation_metrics.gypi#newcode11 components/navigation_metrics.gypi:11: '../base/base.gyp:base', you also depend on url, no? https://codereview.chromium.org/35693009/diff/1/components/navigation_metrics/navigation_metrics.h ...

7 years, 2 months ago (2013-10-23 14:46:09 UTC) #2

cbentzel

Thanks for the fast review. https://codereview.chromium.org/35693009/diff/1/components/navigation_metrics.gypi File components/navigation_metrics.gypi (right): https://codereview.chromium.org/35693009/diff/1/components/navigation_metrics.gypi#newcode11 components/navigation_metrics.gypi:11: '../base/base.gyp:base', On 2013/10/23 14:46:10, ...

7 years, 2 months ago (2013-10-23 15:19:45 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/35693009/290001

7 years, 2 months ago (2013-10-23 17:13:55 UTC) #5

Message was sent while issue was closed.

Change committed as 230508

Expand Messages | Collapse Messages