Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 35693008: Remove dead code for webkitvisibilitychange in Document (Closed)

Created:
7 years, 2 months ago by philipj_slow
Modified:
7 years, 2 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove dead code for webkitvisibilitychange in Document There's no attribute EventHandler onwebkitvisibilitychange in the IDL, so the DEFINE_ATTRIBUTE_EVENT_LISTENER would just output dead code. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/core/dom/Document.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
Found this while working on http://code.google.com/p/chromium/issues/detail?id=305112
7 years, 2 months ago (2013-10-23 13:28:52 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 2 months ago (2013-10-23 14:05:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/35693008/1
7 years, 2 months ago (2013-10-23 14:13:00 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-23 15:25:29 UTC) #4
Message was sent while issue was closed.
Change committed as 160346

Powered by Google App Engine
This is Rietveld 408576698