Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1076)

Unified Diff: runtime/vm/simulator_arm.cc

Issue 356923006: Iterate over PcDescriptors only via iterators, not via an index. (preparation for more compression … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/simulator_arm.cc
===================================================================
--- runtime/vm/simulator_arm.cc (revision 38030)
+++ runtime/vm/simulator_arm.cc (working copy)
@@ -269,12 +269,13 @@
intptr_t token_pos = -1;
const PcDescriptors& descriptors =
PcDescriptors::Handle(code.pc_descriptors());
- for (intptr_t i = 0; i < descriptors.Length(); i++) {
- if (descriptors.PC(i) == pc) {
- token_pos = descriptors.TokenPos(i);
- break;
- } else if ((token_pos <= 0) && (descriptors.PC(i) > pc)) {
- token_pos = descriptors.TokenPos(i);
+ PcDescriptors::Iterator iter(descriptors);
+ while (iter.HasNext()) {
+ const RawPcDescriptors::PcDescriptorRec& rec = iter.Next();
+ if (rec.pc == pc) {
+ return rec.token_pos;
+ } else if ((token_pos <= 0) && (rec.pc > pc)) {
+ token_pos = rec.token_pos;
}
}
return token_pos;
« runtime/vm/debugger.cc ('K') | « runtime/vm/raw_object.h ('k') | runtime/vm/stack_frame.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698