Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Unified Diff: runtime/vm/intermediate_language_arm64.cc

Issue 356923006: Iterate over PcDescriptors only via iterators, not via an index. (preparation for more compression … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_arm64.cc
===================================================================
--- runtime/vm/intermediate_language_arm64.cc (revision 38030)
+++ runtime/vm/intermediate_language_arm64.cc (working copy)
@@ -214,7 +214,7 @@
__ LoadImmediate(R5, 0, PP);
__ AddImmediate(R2, R2, Instructions::HeaderSize() - kHeapObjectTag, PP);
__ blr(R2);
- compiler->AddCurrentDescriptor(PcDescriptors::kClosureCall,
+ compiler->AddCurrentDescriptor(RawPcDescriptors::kClosureCall,
deopt_id(),
token_pos());
compiler->RecordSafepoint(locs());
@@ -226,7 +226,7 @@
} else {
// Add deoptimization continuation point after the call and before the
// arguments are removed.
- compiler->AddCurrentDescriptor(PcDescriptors::kDeopt,
+ compiler->AddCurrentDescriptor(RawPcDescriptors::kDeopt,
deopt_id_after,
token_pos());
}
@@ -796,7 +796,7 @@
__ LoadImmediate(R1, argc_tag, PP);
compiler->GenerateCall(token_pos(),
stub_entry,
- PcDescriptors::kOther,
+ RawPcDescriptors::kOther,
locs());
__ Pop(result);
}
@@ -1619,7 +1619,7 @@
compiler->SaveLiveRegisters(locs);
compiler->GenerateCall(Scanner::kNoSourcePos, // No token position.
&label,
- PcDescriptors::kOther,
+ RawPcDescriptors::kOther,
locs);
__ mov(locs->temp(0).reg(), R0);
compiler->RestoreLiveRegisters(locs);
@@ -1964,7 +1964,7 @@
ASSERT(locs()->in(kLengthPos).reg() == R2);
compiler->GenerateCall(token_pos(),
&StubCode::AllocateArrayLabel(),
- PcDescriptors::kOther,
+ RawPcDescriptors::kOther,
locs());
ASSERT(locs()->out(0).reg() == R0);
}
@@ -1989,7 +1989,7 @@
compiler->SaveLiveRegisters(locs);
compiler->GenerateCall(Scanner::kNoSourcePos, // No token position.
&label,
- PcDescriptors::kOther,
+ RawPcDescriptors::kOther,
locs);
__ mov(locs->out(0).reg(), R0);
compiler->RestoreLiveRegisters(locs);
@@ -2021,7 +2021,7 @@
compiler->SaveLiveRegisters(locs);
compiler->GenerateCall(Scanner::kNoSourcePos, // No token position.
&label,
- PcDescriptors::kOther,
+ RawPcDescriptors::kOther,
locs);
__ mov(locs->out(0).reg(), R0);
compiler->RestoreLiveRegisters(locs);
@@ -2053,7 +2053,7 @@
compiler->SaveLiveRegisters(locs);
compiler->GenerateCall(Scanner::kNoSourcePos, // No token position.
&label,
- PcDescriptors::kOther,
+ RawPcDescriptors::kOther,
locs);
__ mov(locs->out(0).reg(), R0);
compiler->RestoreLiveRegisters(locs);
@@ -2329,7 +2329,7 @@
const ExternalLabel label(StubCode::AllocateContextEntryPoint());
compiler->GenerateCall(token_pos(),
&label,
- PcDescriptors::kOther,
+ RawPcDescriptors::kOther,
locs());
}
@@ -2442,7 +2442,7 @@
if (FLAG_use_osr && !compiler->is_optimizing() && instruction_->in_loop()) {
// In unoptimized code, record loop stack checks as possible OSR entries.
- compiler->AddCurrentDescriptor(PcDescriptors::kOsrEntry,
+ compiler->AddCurrentDescriptor(RawPcDescriptors::kOsrEntry,
instruction_->deopt_id(),
0); // No token position.
}
@@ -3208,7 +3208,7 @@
compiler->SaveLiveRegisters(locs);
compiler->GenerateCall(Scanner::kNoSourcePos, // No token position.
&label,
- PcDescriptors::kOther,
+ RawPcDescriptors::kOther,
locs);
__ mov(locs->out(0).reg(), R0);
compiler->RestoreLiveRegisters(locs);
@@ -5168,7 +5168,7 @@
// On ARM64 the deoptimization descriptor points after the edge counter
// code so that we can reuse the same pattern matching code as at call
// sites, which matches backwards from the end of the pattern.
- compiler->AddCurrentDescriptor(PcDescriptors::kDeopt,
+ compiler->AddCurrentDescriptor(RawPcDescriptors::kDeopt,
deopt_id_,
Scanner::kNoSourcePos);
}
@@ -5194,7 +5194,7 @@
// points after the edge counter code so that we can reuse the same
// pattern matching code as at call sites, which matches backwards from
// the end of the pattern.
- compiler->AddCurrentDescriptor(PcDescriptors::kDeopt,
+ compiler->AddCurrentDescriptor(RawPcDescriptors::kDeopt,
GetDeoptId(),
Scanner::kNoSourcePos);
}
@@ -5336,7 +5336,7 @@
const ExternalLabel label(stub.EntryPoint());
compiler->GenerateCall(token_pos(),
&label,
- PcDescriptors::kOther,
+ RawPcDescriptors::kOther,
locs());
__ Drop(ArgumentCount()); // Discard arguments.
}

Powered by Google App Engine
This is Rietveld 408576698