Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: runtime/vm/debugger_arm64.cc

Issue 356923006: Iterate over PcDescriptors only via iterators, not via an index. (preparation for more compression … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/debugger_arm64.cc
===================================================================
--- runtime/vm/debugger_arm64.cc (revision 38030)
+++ runtime/vm/debugger_arm64.cc (working copy)
@@ -52,10 +52,10 @@
{
WritableInstructionsScope writable(instrs.EntryPoint(), instrs.size());
switch (breakpoint_kind_) {
- case PcDescriptors::kIcCall:
- case PcDescriptors::kUnoptStaticCall:
- case PcDescriptors::kRuntimeCall:
- case PcDescriptors::kClosureCall: {
+ case RawPcDescriptors::kIcCall:
+ case RawPcDescriptors::kUnoptStaticCall:
+ case RawPcDescriptors::kRuntimeCall:
+ case RawPcDescriptors::kClosureCall: {
int32_t offset = CodePatcher::GetPoolOffsetAt(pc_);
ASSERT((offset > 0) && ((offset & 0x7) == 0));
saved_value_ = static_cast<uword>(offset);
@@ -80,10 +80,10 @@
{
WritableInstructionsScope writable(instrs.EntryPoint(), instrs.size());
switch (breakpoint_kind_) {
- case PcDescriptors::kIcCall:
- case PcDescriptors::kUnoptStaticCall:
- case PcDescriptors::kClosureCall:
- case PcDescriptors::kRuntimeCall: {
+ case RawPcDescriptors::kIcCall:
+ case RawPcDescriptors::kUnoptStaticCall:
+ case RawPcDescriptors::kClosureCall:
+ case RawPcDescriptors::kRuntimeCall: {
CodePatcher::SetPoolOffsetAt(pc_, static_cast<int32_t>(saved_value_));
break;
}

Powered by Google App Engine
This is Rietveld 408576698