Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: runtime/vm/debugger.h

Issue 356923006: Iterate over PcDescriptors only via iterators, not via an index. (preparation for more compression … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/debugger.h
===================================================================
--- runtime/vm/debugger.h (revision 38030)
+++ runtime/vm/debugger.h (working copy)
@@ -79,7 +79,8 @@
// function gets compiled as a regular function and as a closure.
class CodeBreakpoint {
public:
- CodeBreakpoint(const Code& code, intptr_t pc_desc_index);
+ CodeBreakpoint(const Code& code,
+ const RawPcDescriptors::PcDescriptorRec& rec);
~CodeBreakpoint();
RawFunction* function() const;
@@ -105,13 +106,11 @@
void set_next(CodeBreakpoint* value) { next_ = value; }
CodeBreakpoint* next() const { return this->next_; }
- intptr_t pc_desc_index() const { return pc_desc_index_; }
void PatchCode();
void RestoreCode();
RawCode* code_;
- intptr_t pc_desc_index_;
intptr_t token_pos_;
uword pc_;
intptr_t line_number_;
@@ -120,7 +119,7 @@
SourceBreakpoint* src_bpt_;
CodeBreakpoint* next_;
- PcDescriptors::Kind breakpoint_kind_;
+ RawPcDescriptors::Kind breakpoint_kind_;
uword saved_value_;
friend class Debugger;
@@ -191,7 +190,6 @@
intptr_t frame_ctx_level,
intptr_t var_ctx_level);
- intptr_t PcDescIndex();
intptr_t TryIndex();
void GetPcDescriptors();
void GetVarDescriptors();
@@ -214,7 +212,8 @@
const Code& code_;
const Function& function_;
intptr_t token_pos_;
- intptr_t pc_desc_index_;
+ const RawPcDescriptors::PcDescriptorRec* desc_rec_;
+
intptr_t line_number_;
intptr_t column_number_;
intptr_t context_level_;
« no previous file with comments | « runtime/vm/coverage.cc ('k') | runtime/vm/debugger.cc » ('j') | runtime/vm/debugger.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698