Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: runtime/vm/code_descriptors_test.cc

Issue 356923006: Iterate over PcDescriptors only via iterators, not via an index. (preparation for more compression … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/code_descriptors_test.cc
===================================================================
--- runtime/vm/code_descriptors_test.cc (revision 38030)
+++ runtime/vm/code_descriptors_test.cc (working copy)
@@ -257,9 +257,11 @@
const PcDescriptors& descriptors =
PcDescriptors::Handle(code.pc_descriptors());
int call_count = 0;
- for (int i = 0; i < descriptors.Length(); ++i) {
- if (descriptors.DescriptorKind(i) == PcDescriptors::kUnoptStaticCall) {
- stackmap_table_builder->AddEntry(descriptors.PC(i) - code.EntryPoint(),
+ PcDescriptors::Iterator iter(descriptors);
+ while (iter.HasNext()) {
+ const RawPcDescriptors::PcDescriptorRec& rec = iter.Next();
+ if (rec.kind() == RawPcDescriptors::kUnoptStaticCall) {
+ stackmap_table_builder->AddEntry(rec.pc - code.EntryPoint(),
stack_bitmap,
0);
++call_count;
« no previous file with comments | « runtime/vm/code_descriptors.cc ('k') | runtime/vm/coverage.cc » ('j') | runtime/vm/debugger.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698