Chromium Code Reviews| Index: ppapi/native_client/src/trusted/plugin/pnacl_resources.h |
| diff --git a/ppapi/native_client/src/trusted/plugin/pnacl_resources.h b/ppapi/native_client/src/trusted/plugin/pnacl_resources.h |
| index dcc521ec5983258a95596a2d8d0c36c59292f565..5bec4c6cf942f46d547ee13d8b6912547d125ef1 100644 |
| --- a/ppapi/native_client/src/trusted/plugin/pnacl_resources.h |
| +++ b/ppapi/native_client/src/trusted/plugin/pnacl_resources.h |
| @@ -12,7 +12,7 @@ |
| #include "native_client/src/include/nacl_string.h" |
| #include "native_client/src/trusted/desc/nacl_desc_wrapper.h" |
| -#include "ppapi/c/private/pp_file_handle.h" |
| +#include "ppapi/c/private/ppb_nacl_private.h" |
| #include "ppapi/cpp/completion_callback.h" |
| #include "ppapi/native_client/src/trusted/plugin/plugin_error.h" |
| @@ -26,11 +26,7 @@ class Plugin; |
| // and point to pnacl component filesystem resources. |
| class PnaclResources { |
| public: |
| - explicit PnaclResources(Plugin* plugin) |
| - : plugin_(plugin), |
| - llc_file_handle_(PP_kInvalidFileHandle), |
| - ld_file_handle_(PP_kInvalidFileHandle) { |
| - } |
| + explicit PnaclResources(Plugin* plugin); |
| virtual ~PnaclResources(); |
| // Read the resource info JSON file. This is the first step after |
| @@ -43,8 +39,8 @@ class PnaclResources { |
| const nacl::string& GetLlcUrl() { return llc_tool_name_; } |
| const nacl::string& GetLdUrl() { return ld_tool_name_; } |
| - PP_FileHandle TakeLlcFileHandle(); |
| - PP_FileHandle TakeLdFileHandle(); |
| + PP_NaClFileInfo TakeLlcFileInfo(); |
| + PP_NaClFileInfo TakeLdFileInfo(); |
| private: |
| NACL_DISALLOW_COPY_AND_ASSIGN(PnaclResources); |
| @@ -56,11 +52,11 @@ class PnaclResources { |
| nacl::string llc_tool_name_; |
| nacl::string ld_tool_name_; |
| - // File handles for llc and ld executables, after they've been opened. |
| + // File handles / info for llc and ld executables, after they've been opened. |
|
teravest
2014/06/26 21:19:24
you can drop the "handles /" here.
jvoung (off chromium)
2014/06/26 22:48:39
Done.
|
| // Only valid after the callback for StartLoad() has been called, and until |
| // TakeLlcFileHandle()/TakeLdFileHandle() is called. |
| - PP_FileHandle llc_file_handle_; |
| - PP_FileHandle ld_file_handle_; |
| + PP_NaClFileInfo llc_file_info_; |
| + PP_NaClFileInfo ld_file_info_; |
| }; |
| } // namespace plugin; |