ppapi/api/private/ppb_nacl_private.idl - Issue 356923004: Enable mmap and identity-based validation caching on pnacl-{llc,ld}.nexe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/api/private/ppb_nacl_private.idl

Issue 356923004: Enable mmap and identity-based validation caching on pnacl-{llc,ld}.nexe (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: adjust expectations for other UMA test Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/nacl/renderer/ppb_nacl_private_impl.cc ('K') | « components/nacl/renderer/ppb_nacl_private_impl.cc ('k') | ppapi/c/private/ppb_nacl_private.h » ('j') | ppapi/native_client/src/trusted/plugin/plugin.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/api/private/ppb_nacl_private.idl

diff --git a/ppapi/api/private/ppb_nacl_private.idl b/ppapi/api/private/ppb_nacl_private.idl

index 2168d4f87dfe2541421b9bd4e17474cb7d41b088..cb2a0f32a0085291bcf5b413915074ebb3a98ed9 100644

--- a/ppapi/api/private/ppb_nacl_private.idl

+++ b/ppapi/api/private/ppb_nacl_private.idl

@@ -236,10 +236,11 @@ interface PPB_NaCl_Private {

[in] uint32_t desired_access,

[in] uint32_t options);

- /* Returns a read-only file descriptor for a url for pnacl translator tools,

- * or an invalid handle on failure.

+ /* Returns a read-only (but executable) file descriptor / file info for

+ * a url for pnacl translator tools. Returns an invalid handle on failure.

- PP_FileHandle GetReadonlyPnaclFd([in] str_t url);

+ void GetReadExecPnaclFd([in] str_t url,

+ [out] PP_NaClFileInfo out_file_info);

/* This creates a temporary file that will be deleted by the time

* the last handle is closed (or earlier on POSIX systems), and