Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc

Issue 356923002: Pepper: Move Pnacl init time out of trusted plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc
diff --git a/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc b/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc
index 0c453c848cd821a80c135bdcac02e6bc27d32e72..53cba75139bf61acafdf4e1fddf5174124af636b 100644
--- a/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc
+++ b/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc
@@ -82,7 +82,7 @@ PnaclCoordinator* PnaclCoordinator::BitcodeToNative(
pnacl_options,
translate_notify_callback);
- coordinator->pnacl_init_time_ = NaClGetTimeOfDayMicroseconds();
+ GetNaClInterface()->SetPNaClStartTime(plugin->pp_instance());
int cpus = plugin->nacl_interface()->GetNumberOfProcessors();
coordinator->split_module_count_ = std::min(4, std::max(1, cpus));
@@ -109,7 +109,6 @@ PnaclCoordinator::PnaclCoordinator(
split_module_count_(1),
is_cache_hit_(PP_FALSE),
error_already_reported_(false),
- pnacl_init_time_(0),
pexe_size_(0),
pexe_bytes_compiled_(0),
expected_pexe_size_(-1) {
@@ -132,7 +131,7 @@ PnaclCoordinator::~PnaclCoordinator() {
if (!translation_finished_reported_) {
plugin_->nacl_interface()->ReportTranslationFinished(
plugin_->pp_instance(),
- PP_FALSE, 0, 0, 0, 0);
+ PP_FALSE, 0, 0, 0);
}
// Force deleting the translate_thread now. It must be deleted
// before any scoped_* fields hanging off of PnaclCoordinator
@@ -181,7 +180,7 @@ void PnaclCoordinator::ExitWithError() {
translation_finished_reported_ = true;
plugin_->nacl_interface()->ReportTranslationFinished(
plugin_->pp_instance(),
- PP_FALSE, 0, 0, 0, 0);
+ PP_FALSE, 0, 0, 0);
translate_notify_callback_.Run(PP_ERROR_FAILED);
} else {
PLUGIN_PRINTF(("PnaclCoordinator::ExitWithError an earlier error was "
@@ -230,13 +229,12 @@ void PnaclCoordinator::TranslateFinished(int32_t pp_error) {
// pointer to be able to read it again from the beginning.
temp_nexe_file_->Reset();
- int64_t total_time = NaClGetTimeOfDayMicroseconds() - pnacl_init_time_;
// Report to the browser that translation finished. The browser will take
// care of storing the nexe in the cache.
translation_finished_reported_ = true;
plugin_->nacl_interface()->ReportTranslationFinished(
plugin_->pp_instance(), PP_TRUE, pnacl_options_.opt_level,
- pexe_size_, translate_thread_->GetCompileTime(), total_time);
+ pexe_size_, translate_thread_->GetCompileTime());
NexeReadDidOpen(PP_OK);
}

Powered by Google App Engine
This is Rietveld 408576698