Issue 356913003: Don't set SK_MALLOC_TEMP in SkAutoTMalloc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 356913003: Don't set SK_MALLOC_TEMP in SkAutoTMalloc. (Closed)

Created:
6 years, 6 months ago by mtklein_C

Modified:
6 years, 6 months ago

Reviewers:
hal.canary, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Don't set SK_MALLOC_TEMP in SkAutoTMalloc. Unlike SkAutoSTMalloc, it doesn't make sense for SkAutoTMalloc to set SK_MALLOC_TEMP. See SkAutoMalloc/SkAutoSMalloc for similar in the void* world.(This change is a documentation-only no-op. No code pays any attention to SK_MALLOC_TEMP.) BUG=skia: R=halcanary@google.com Committed: https://skia.googlesource.com/skia/+/93fabf4

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	include/core/SkTemplates.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r93fabf4.

Expand Messages | Collapse Messages