Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 356903006: Make TextTrackCue's readonly attribute TextTrack? track nullable (Closed)

Created:
6 years, 5 months ago by philipj_slow
Modified:
6 years, 5 months ago
Reviewers:
haraken, Jens Widell
CC:
blink-reviews, nessy, arv+blink, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, watchdog-blink-watchlist_google.com, dglazkov+blink, Inactive, vcarbune.chromium, philipj_slow
Project:
blink
Visibility:
Public.

Description

Make TextTrackCue's readonly attribute TextTrack? track nullable http://whatwg.org/html#texttrackcue TEST=LayoutTests/media/track/opera/interfaces/TextTrackCue/track.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/html/track/TextTrackCue.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL. Thanks to Jens, this can finally be fixed without making the C++ code uglier.
6 years, 5 months ago (2014-06-27 23:42:08 UTC) #1
haraken
LGTM. jl@: Great work!
6 years, 5 months ago (2014-06-28 00:10:14 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 5 months ago (2014-06-28 07:52:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/356903006/1
6 years, 5 months ago (2014-06-28 07:53:32 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-06-28 22:44:57 UTC) #5
Message was sent while issue was closed.
Change committed as 177168

Powered by Google App Engine
This is Rietveld 408576698