Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Side by Side Diff: src/x64/ic-x64.cc

Issue 3569002: Backport r5553 "Do not invoke indexed interceptor getters for negative indice... (Closed) Base URL: http://v8.googlecode.com/svn/branches/2.3/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/version.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 900 matching lines...) Expand 10 before | Expand all | Expand 10 after
911 // ----------- S t a t e ------------- 911 // ----------- S t a t e -------------
912 // -- rax : key 912 // -- rax : key
913 // -- rdx : receiver 913 // -- rdx : receiver
914 // -- rsp[0] : return address 914 // -- rsp[0] : return address
915 // ----------------------------------- 915 // -----------------------------------
916 Label slow; 916 Label slow;
917 917
918 // Check that the receiver isn't a smi. 918 // Check that the receiver isn't a smi.
919 __ JumpIfSmi(rdx, &slow); 919 __ JumpIfSmi(rdx, &slow);
920 920
921 // Check that the key is a smi. 921 // Check that the key is an array index, that is Uint32.
922 __ JumpIfNotSmi(rax, &slow); 922 __ JumpIfNotPositiveSmi(rax, &slow);
923 923
924 // Get the map of the receiver. 924 // Get the map of the receiver.
925 __ movq(rcx, FieldOperand(rdx, HeapObject::kMapOffset)); 925 __ movq(rcx, FieldOperand(rdx, HeapObject::kMapOffset));
926 926
927 // Check that it has indexed interceptor and access checks 927 // Check that it has indexed interceptor and access checks
928 // are not enabled for this object. 928 // are not enabled for this object.
929 __ movb(rcx, FieldOperand(rcx, Map::kBitFieldOffset)); 929 __ movb(rcx, FieldOperand(rcx, Map::kBitFieldOffset));
930 __ andb(rcx, Immediate(kSlowCaseBitFieldMask)); 930 __ andb(rcx, Immediate(kSlowCaseBitFieldMask));
931 __ cmpb(rcx, Immediate(1 << Map::kHasIndexedInterceptor)); 931 __ cmpb(rcx, Immediate(1 << Map::kHasIndexedInterceptor));
932 __ j(not_zero, &slow); 932 __ j(not_zero, &slow);
(...skipping 980 matching lines...) Expand 10 before | Expand all | Expand 10 after
1913 GenerateMiss(masm); 1913 GenerateMiss(masm);
1914 } 1914 }
1915 1915
1916 1916
1917 #undef __ 1917 #undef __
1918 1918
1919 1919
1920 } } // namespace v8::internal 1920 } } // namespace v8::internal
1921 1921
1922 #endif // V8_TARGET_ARCH_X64 1922 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/version.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698