Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: src/arm/ic-arm.cc

Issue 3569002: Backport r5553 "Do not invoke indexed interceptor getters for negative indice... (Closed) Base URL: http://v8.googlecode.com/svn/branches/2.3/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/ic-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1584 matching lines...) Expand 10 before | Expand all | Expand 10 after
1595 // ---------- S t a t e -------------- 1595 // ---------- S t a t e --------------
1596 // -- lr : return address 1596 // -- lr : return address
1597 // -- r0 : key 1597 // -- r0 : key
1598 // -- r1 : receiver 1598 // -- r1 : receiver
1599 // ----------------------------------- 1599 // -----------------------------------
1600 Label slow; 1600 Label slow;
1601 1601
1602 // Check that the receiver isn't a smi. 1602 // Check that the receiver isn't a smi.
1603 __ BranchOnSmi(r1, &slow); 1603 __ BranchOnSmi(r1, &slow);
1604 1604
1605 // Check that the key is a smi. 1605 // Check that the key is an array index, that is Uint32.
1606 __ BranchOnNotSmi(r0, &slow); 1606 __ tst(r0, Operand(kSmiTagMask | kSmiSignMask));
1607 __ b(ne, &slow);
1607 1608
1608 // Get the map of the receiver. 1609 // Get the map of the receiver.
1609 __ ldr(r2, FieldMemOperand(r1, HeapObject::kMapOffset)); 1610 __ ldr(r2, FieldMemOperand(r1, HeapObject::kMapOffset));
1610 1611
1611 // Check that it has indexed interceptor and access checks 1612 // Check that it has indexed interceptor and access checks
1612 // are not enabled for this object. 1613 // are not enabled for this object.
1613 __ ldrb(r3, FieldMemOperand(r2, Map::kBitFieldOffset)); 1614 __ ldrb(r3, FieldMemOperand(r2, Map::kBitFieldOffset));
1614 __ and_(r3, r3, Operand(kSlowCaseBitFieldMask)); 1615 __ and_(r3, r3, Operand(kSlowCaseBitFieldMask));
1615 __ cmp(r3, Operand(1 << Map::kHasIndexedInterceptor)); 1616 __ cmp(r3, Operand(1 << Map::kHasIndexedInterceptor));
1616 __ b(ne, &slow); 1617 __ b(ne, &slow);
(...skipping 651 matching lines...) Expand 10 before | Expand all | Expand 10 after
2268 GenerateMiss(masm); 2269 GenerateMiss(masm);
2269 } 2270 }
2270 2271
2271 2272
2272 #undef __ 2273 #undef __
2273 2274
2274 2275
2275 } } // namespace v8::internal 2276 } } // namespace v8::internal
2276 2277
2277 #endif // V8_TARGET_ARCH_ARM 2278 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/ic-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698