Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 356893002: Add UMA for --app-shim-error. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index cfa152a82e82c983a69e7ed2bff3375856d50506..57b59f95f6e51932dd3aa5e35262acdf5e6ce5e0 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -476,6 +476,16 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="Apps.AppShimError" enum="AppShimError">
+ <owner>jackhou@chromium.org</owner>
+ <summary>
+ Counts which versions of app_mode_loader are sending --app-shim-error.
+ --app-shim-error is sent as a command line argument to Chrome when
+ app_mode_loader was unable to dyload the Chrome Framework and call
+ ChromeAppModeMain.
+ </summary>
+</histogram>
+
<histogram name="Ash.ActiveTouchPoints">
<owner>kuscher@google.com</owner>
<owner>rbyers@chromium.org</owner>
@@ -34220,6 +34230,12 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<int value="4" label="PROMO_SEEN"/>
</enum>
+<enum name="AppShimError" type="int">
+ <int value="0" label="Shim was version 37 or lower."/>
tapted 2014/07/01 12:48:11 this needs updating for the UNKNOWN case
jackhou1 2014/07/02 03:18:12 Done.
+ <int value="1" label="Shim was version 38."/>
+ <int value="2" label="Shim was version 39 or higher."/>
+</enum>
+
<enum name="AppsPageDragSource" type="int">
<int value="0" label="Same apps pane"/>
<int value="1" label="Different apps pane"/>
« chrome/browser/web_applications/web_app_mac.mm ('K') | « chrome/common/mac/app_mode_common.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698