tools/metrics/histograms/histograms.xml - Issue 356893002: Add UMA for --app-shim-error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 356893002: Add UMA for --app-shim-error. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 46950fa1c40c546257ea96f0fe19104718a4105c..1ff71d47f4d0c8948c2dad9de758e4fb1ad542d4 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -476,6 +476,17 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="Apps.AppShimErrorVersion">

+ <owner>jackhou@chromium.org</owner>

+ <summary>

+ Counts which major milestone versions of app_mode_loader are sending

+ --app-shim-error. --app-shim-error is sent as a command line argument to

+ Chrome when app_mode_loader was unable to dyload the Chrome Framework and

+ call ChromeAppModeMain. E.g. when Chrome updates from 32-bit to 64-bit, a

Ilya Sherman 2014/07/07 23:07:57 nit: "a older" -> "an older"

Ilya Sherman 2014/07/07 23:07:57 nit: "E.g." -> "For example,"

jackhou1 2014/07/08 01:10:23 Done.

+ older shim will find the new framework version but fail to dyload it.

+ </summary>

+</histogram>

<owner>kuscher@google.com</owner>

<owner>rbyers@chromium.org</owner>

« no previous file with comments | « chrome/common/mac/app_mode_common.mm ('k') | no next file » | no next file with comments »